Skip to content

K
k3s
Commit 078a3b65 authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub
Browse files
Options

Merge pull request #50607 from lukaszo/logdns

Automatic merge from submit-queue (batch tested with PRs 50531, 50853, 49976, 50939, 50607) Log error from ensureDNSRecords Hiding errors is not a good idea. It took me some time to figure it out why my coredns is not working. It turned out that I had wrong etcd configuration but errors about it were hidden. ```release-note NONE ```
parents 5bd67f2b 3ebb1400
Hide whitespace changes
Inline Side-by-side
Showing with 1 addition and 0 deletions
federation/pkg/federation-controller/service/dns/dns.go
View file @ 078a3b65
...@@ -182,6 +182,7 @@ func (s *ServiceDNSController) workerFunction() bool { ...@@ -182,6 +182,7 @@ func (s *ServiceDNSController) workerFunction() bool {
for _, clusterIngress := range ingress.Items { for _, clusterIngress := range ingress.Items {
err = s.ensureDNSRecords(clusterIngress.Cluster, service) err = s.ensureDNSRecords(clusterIngress.Cluster, service)
if err != nil { if err != nil {
runtime.HandleError(fmt.Errorf("Error when ensuring DNS records for service %s/%s: %v", service.Namespace, service.Name, err))
s.deliverService(service, 0, true) s.deliverService(service, 0, true)
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment