Merge pull request #56294 from xiangpengzhao/kubeadm-minor-cleanup

cmd/kubeadm/app/BUILD

@@ -44,7 +44,6 @@ filegroup(
         "//cmd/kubeadm/app/phases/kubelet:all-srcs",
         "//cmd/kubeadm/app/phases/markmaster:all-srcs",
         "//cmd/kubeadm/app/phases/selfhosting:all-srcs",
-        "//cmd/kubeadm/app/phases/token:all-srcs",
         "//cmd/kubeadm/app/phases/upgrade:all-srcs",
         "//cmd/kubeadm/app/phases/uploadconfig:all-srcs",
         "//cmd/kubeadm/app/preflight:all-srcs",

cmd/kubeadm/app/apis/kubeadm/fuzzer/fuzzer.go

@@ -116,7 +116,6 @@ func Funcs(codecs runtimeserializer.CodecFactory) []interface{} {
 		func(obj *kubeadm.NodeConfiguration, c fuzz.Continue) {
 			c.FuzzNoCustom(obj)
 			obj.CACertPath = "foo"
-			obj.CACertPath = "foo"
 			obj.DiscoveryFile = "foo"
 			obj.DiscoveryToken = "foo"
 			obj.DiscoveryTokenAPIServers = []string{"foo"}

cmd/kubeadm/app/cmd/token.go

@@ -390,8 +390,7 @@ func getClientset(file string, dryRun bool) (clientset.Interface, error) {
 		}
 		return apiclient.NewDryRunClient(dryRunGetter, os.Stdout), nil
 	}
-	client, err := kubeconfigutil.ClientSetFromFile(file)
-	return client, err
+	return kubeconfigutil.ClientSetFromFile(file)
 }
 
 func getJoinCommand(token string, kubeConfigFile string) (string, error) {

cmd/kubeadm/app/phases/token/BUILD

-package(default_visibility = ["//visibility:public"])
-
-filegroup(
-    name = "package-srcs",
-    srcs = glob(["**"]),
-    tags = ["automanaged"],
-    visibility = ["//visibility:private"],
-)
-
-filegroup(
-    name = "all-srcs",
-    srcs = [":package-srcs"],
-    tags = ["automanaged"],
-)

cmd/kubeadm/app/phases/upgrade/postupgrade.go

@@ -62,7 +62,7 @@ func PerformPostUpgradeTasks(client clientset.Interface, cfg *kubeadmapi.MasterC
 		errs = append(errs, err)
 	}
 
-	// Create/update RBAC rules that makes the 1.8.0+ nodes to rotate certificates and get their CSRs approved automatically
+	// Create/update RBAC rules that makes the nodes to rotate certificates and get their CSRs approved automatically
 	if err := nodebootstraptoken.AutoApproveNodeCertificateRotation(client); err != nil {
 		errs = append(errs, err)
 	}