• Kubernetes Submit Queue's avatar
    Merge pull request #52165 from… · 6a02660f
    Kubernetes Submit Queue authored
    Merge pull request #52165 from mattjmcnaughton/mattjmcnaughton/52025-more-descriptive-make-test-error-message
    
    Automatic merge from submit-queue (batch tested with PRs 53101, 53158, 52165). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    More descriptive error message for `make test`
    
    **Which issue this PR fixes**
    Fix #52025
    
    **What this PR does / why we need it**:
    
    The `[packages]` argument to `go test` can be confusing. If the
    `package` does not begin with `./`, `go test` considers it relative to
    `$GOPATH/src`. If it does begin with `./`, `go test` considers it
    relative to `pwd`. `hack/make-rules/test.sh`, and thus `make test`, use
    `go test`.
    
    This commit adds a verify step to `hack/make-rules/test.sh`. Before we
    run `go test`, we check the packages under test exist. If the user
    specified the package path in the incorrect format - for example they
    didn't prepend with `./` when they should have, the check logs a
    suggestion of the alternative path they should use.
    
    Running the test suites for a package is an activity many all first time
    contributors will take. Hopefully including a more descriptive error
    message, with a suggestion for a fix if applicable, will make this an
    easier experience.
    Signed-off-by: 's avatarmattjmcnaughton <mattjmcnaughton@gmail.com>
    
    ```release-note
    NONE
    ```
    6a02660f
test.sh 15.1 KB