• Anish Bhatt's avatar
    Fix extraneous entries in iscsi path format · 6d9e9561
    Anish Bhatt authored
    Code comments currently claim the default iscsi mount path as
    
    kubernetes.io/pod/iscsi/<portal>-iqn-<iqn>-lun-<id>, however actual
    path being used is
    kubernetes.io/iscsi/iscsi/<portal>-iqn-<iqn>-lun-<id>
    
    This leads to ultimate path being similar to this :
    
    kubernetes.io/iscsi/iscsi/...iqn-iqn...-lun-N
    
    Both iscsi and iqn are repated twice for no reason, since "iqn" is
    required by spec to be part of an iqn. This is also  wrong on
    multiple leves as actual allowed naming formats are :
    
    iqn.2001-04.com.example:storage:diskarrays-sn-a8675309
    eui.02004567A425678D
    (RFC 3720 3.2.6.3)
    
    and in the second case "iqn-eui" in the path would be misleading.
    
    Change this to a more reasonable path of
    kubernetes.io/iscsi/<portal>-<iqn>-lun-<id>
    
    which also aligns up with how the /dev/by-path and sysfs entries
    are created for iscsi devices on linux
    
      * -- *
    
    Update iSCSI README and sample json file
    
    There seems to have been quite a skew in recent updates to these
    files adding in wrong info or info that no longer lines up the
    sample config with the README.
    
    Fixed the following issues :
    * Fix discrepancy in samples json using initiator iqn from previous
      linked example as target iqn (which was just wrong)
    * Generate sample output and README from the same json config provided.
    * Remove recommendation to edit initiator name, this is not required
      (open-iscsi warns against editing this manually and provides a utility
       for the same)
    * Update docker inspect command to one that works.
    * Use separate LUNs for separate mount points instead of re-using.
    6d9e9561
iscsi.json 1.45 KB