• Kubernetes Submit Queue's avatar
    Merge pull request #59301 from dcbw/dockershim-stop-sandbox-no-ip · 1902a18c
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 60435, 60334, 60458, 59301, 60125). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    dockershim: don't check pod IP in StopPodSandbox
    
    We're about to tear the container down, there's no point.  It also suppresses
    an annoying error message due to kubelet stupidity that causes multiple
    parallel calls to StopPodSandbox for the same sandbox.
    
    docker_sandbox.go:355] failed to read pod IP from plugin/docker: NetworkPlugin cni failed on the status hook for pod "docker-registry-1-deploy_default": Unexpected command output nsenter: cannot open /proc/22646/ns/net: No such file or directory
    
    1) A first StopPodSandbox() request triggered by SyncLoop(PLEG) for
    a ContainerDied event calls into TearDownPod() and thus the network
    plugin.  Until this completes, networkReady=true for the
    sandbox.
    
    2) A second StopPodSandbox() request triggered by SyncLoop(REMOVE)
    calls PodSandboxStatus() and calls into the network plugin to read
    the IP address because networkReady=true
    
    3) The first request exits the network plugin, sets networReady=false,
    and calls StopContainer() on the sandbox.  This destroys the network
    namespace.
    
    4) The second request finally gets around to running nsenter but
    the network namespace is already destroyed.  It returns an error
    which is logged by getIP().
    
    ```release-note
    NONE
    ```
    @yujuhong @freehan
    1902a18c
docker_sandbox_test.go 11.1 KB