• Kubernetes Submit Queue's avatar
    Merge pull request #50254 from liggitt/revert-disk-cache · 187e6ab0
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 50254, 50174, 50179)
    
    Revert "Merge pull request #47353 from apelisse/http-cache"
    
    Some issues were discovered with the caching merged in #47353:
    * uses a disk-based cache that is not safe between processes (does not use atomic fs operations)
    * writes get/list responses to disk that should not be cached (like `kubectl get secrets`)
    * is vulnerable to partially written cache responses being used as responses to future requests
    * breaks uses of the client transport that make use of websockets
    * defaults to enabling the cache for any client builder using RecommendedConfigOverrideFlags or DefaultClientConfig which affects more components than just kubectl
    
    This reverts commit fc89743d, reversing changes made to 29ab38e8.
    187e6ab0
helpers.go 28 KB