Merge pull request #60189 from jeffrey4l/log_warning

Automatic merge from submit-queue (batch tested with PRs 60189, 59542, 59931, 60621, 60353). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Log warning message when failed to remove rbd lock It is hard to debug without any error message when lock is not removed successfully.

Merge pull request #60189 from jeffrey4l/log_warning
ffe3bb25 · Kubernetes Submit Queue · GitHub · 1be8e8bb · afbe47a3 · ffe3bb25
Unverified Commit ffe3bb25 authored Mar 20, 2018 by Kubernetes Submit Queue Committed by GitHub Mar 20, 2018
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 0 deletions

rbd_util.go pkg/volume/rbd/rbd_util.go +2 -0

No files found.
--- a/pkg/volume/rbd/rbd_util.go
+++ b/pkg/volume/rbd/rbd_util.go
@@ -346,6 +346,8 @@ func (util *RBDUtil) rbdUnlock(b rbdMounter) error {
 		cmd, err = b.exec.Run("rbd", args...)
 		if err == nil {
 			glog.V(4).Infof("rbd: successfully remove lock (locker_id: %s) on image: %s/%s with id %s mon %s", lock_id, b.Pool, b.Image, b.Id, mon)
+		} else {
+			glog.Warningf("rbd: failed to remove lock (lock_id: %s) on image: %s/%s with id %s mon %s: %v", lock_id, b.Pool, b.Image, b.Id, mon, err)
 		}
 	}