Commit e57e9afb authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub

Merge pull request #49379 from aveshagarwal/master-scheduler-issue

Automatic merge from submit-queue (batch tested with PRs 49326, 49394, 49346, 49379, 49399) Pass clientset's Interface to CreateScheduler. **What this PR does / why we need it**: CreateSchedueler takes clientset.Clientset param and passes it to NewConfigFactory which takes clientset.Interface. It'd be better for CreateSchedueler to take clientset.Interface to be in sync with NewConfigFactory and it would be easier to reuse CreateSchedueler in implementations which relies on interface rather than actual client implementation. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # No issue. @kubernetes/sig-scheduling-pr-reviews @bsalamat
parents a79e6b18 985ce821
...@@ -83,7 +83,7 @@ func createClient(s *options.SchedulerServer) (*clientset.Clientset, *kubernetes ...@@ -83,7 +83,7 @@ func createClient(s *options.SchedulerServer) (*clientset.Clientset, *kubernetes
// CreateScheduler encapsulates the entire creation of a runnable scheduler. // CreateScheduler encapsulates the entire creation of a runnable scheduler.
func CreateScheduler( func CreateScheduler(
s *options.SchedulerServer, s *options.SchedulerServer,
kubecli *clientset.Clientset, kubecli clientset.Interface,
nodeInformer coreinformers.NodeInformer, nodeInformer coreinformers.NodeInformer,
podInformer coreinformers.PodInformer, podInformer coreinformers.PodInformer,
pvInformer coreinformers.PersistentVolumeInformer, pvInformer coreinformers.PersistentVolumeInformer,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment