Merge pull request #46341 from zhangxiaoyu-zidif/add-unittest-for-secret

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add unittest for describe secret **What this PR does / why we need it**: add unittest for describe secret **Release note**: ```release-note NONE ```

Merge pull request #46341 from zhangxiaoyu-zidif/add-unittest-for-secret
e2c31379 · Kubernetes Submit Queue · GitHub · 741beb64 · 25afdbe0 · e2c31379
Unverified Commit e2c31379 authored Nov 01, 2017 by Kubernetes Submit Queue Committed by GitHub Nov 01, 2017
Show whitespace changes
Inline Side-by-side

Showing with 25 additions and 0 deletions

describe_test.go pkg/printers/internalversion/describe_test.go +25 -0

No files found.
--- a/pkg/printers/internalversion/describe_test.go
+++ b/pkg/printers/internalversion/describe_test.go
@@ -126,6 +126,31 @@ func TestDescribePodTolerations(t *testing.T) {
 	}
 }
+func TestDescribeSecret(t *testing.T) {
+	fake := fake.NewSimpleClientset(&api.Secret{
+		ObjectMeta: metav1.ObjectMeta{
+			Name:      "bar",
+			Namespace: "foo",
+		},
+		Data: map[string][]byte{
+			"username": []byte("YWRtaW4="),
+			"password": []byte("MWYyZDFlMmU2N2Rm"),
+		},
+	})
+	c := &describeClient{T: t, Namespace: "foo", Interface: fake}
+	d := SecretDescriber{c}
+	out, err := d.Describe("foo", "bar", printers.DescriberSettings{})
+	if err != nil {
+		t.Errorf("unexpected error: %v", err)
+	}
+	if !strings.Contains(out, "bar") || !strings.Contains(out, "foo") || !strings.Contains(out, "username") || !strings.Contains(out, "8 bytes") || !strings.Contains(out, "password") || !strings.Contains(out, "16 bytes") {
+		t.Errorf("unexpected out: %s", out)
+	}
+	if strings.Contains(out, "YWRtaW4=") || strings.Contains(out, "MWYyZDFlMmU2N2Rm") {
+		t.Errorf("sensitive data should not be shown, unexpected out: %s", out)
+	}
+}
 func TestDescribeNamespace(t *testing.T) {
 	fake := fake.NewSimpleClientset(&api.Namespace{
 		ObjectMeta: metav1.ObjectMeta{