add Get/Set methods, mutex on instanceGroupAttrs.

pkg/cloudprovider/providers/gce/cloud/mock/mock.go

@@ -28,6 +28,7 @@ import (
 	"encoding/json"
 	"fmt"
 	"net/http"
+	"sync"
 
 	alpha "google.golang.org/api/compute/v0.alpha"
 	beta "google.golang.org/api/compute/v0.beta"
@@ -228,44 +229,90 @@ func InsertAlphaAddressHook(ctx context.Context, key *meta.Key, obj *alpha.Addre
 	return convertAndInsertAlphaAddress(key, obj, m.Objects, meta.VersionAlpha, projectID)
 }
 
-// Map from InstanceGroup key to list of Instances
-type instanceGroupAttributes struct {
-	instanceMap map[meta.Key][]*ga.InstanceWithNamedPorts
+// InstanceGroupAttributes maps from InstanceGroup key to a map of Instances
+type InstanceGroupAttributes struct {
+	InstanceMap map[meta.Key]map[string]*ga.InstanceWithNamedPorts
+	Lock        *sync.Mutex
 }
 
-// AddInstancesHook mocks adding instances from an InstanceGroup
-func AddInstancesHook(ctx context.Context, key *meta.Key, req *ga.InstanceGroupsAddInstancesRequest, m *cloud.MockInstanceGroups) error {
-	_, err := m.Get(ctx, key)
-	if err != nil {
-		return &googleapi.Error{
-			Code:    http.StatusNotFound,
-			Message: fmt.Sprintf("Key: %s was not found in InstanceGroups", key.String()),
+// AddInstances adds a list of Instances passed by InstanceReference
+func (igAttrs *InstanceGroupAttributes) AddInstances(key *meta.Key, instanceRefs []*ga.InstanceReference) error {
+	igAttrs.Lock.Lock()
+	defer igAttrs.Lock.Unlock()
+
+	instancesWithNamedPorts, ok := igAttrs.InstanceMap[*key]
+	if !ok {
+		instancesWithNamedPorts = make(map[string]*ga.InstanceWithNamedPorts)
 	}
+
+	for _, instance := range instanceRefs {
+		iWithPort := &ga.InstanceWithNamedPorts{
+			Instance: instance.Instance,
 		}
 
-	if m.X == nil {
-		m.X = instanceGroupAttributes{
-			instanceMap: make(map[meta.Key][]*ga.InstanceWithNamedPorts),
+		instancesWithNamedPorts[instance.Instance] = iWithPort
+	}
+
+	igAttrs.InstanceMap[*key] = instancesWithNamedPorts
+	return nil
+}
+
+// RemoveInstances removes a list of Instances passed by InstanceReference
+func (igAttrs *InstanceGroupAttributes) RemoveInstances(key *meta.Key, instanceRefs []*ga.InstanceReference) error {
+	igAttrs.Lock.Lock()
+	defer igAttrs.Lock.Unlock()
+
+	instancesWithNamedPorts, ok := igAttrs.InstanceMap[*key]
+	if !ok {
+		instancesWithNamedPorts = make(map[string]*ga.InstanceWithNamedPorts)
+	}
+
+	for _, instanceToRemove := range instanceRefs {
+		if _, ok := instancesWithNamedPorts[instanceToRemove.Instance]; ok {
+			delete(instancesWithNamedPorts, instanceToRemove.Instance)
+		} else {
+			return &googleapi.Error{
+				Code:    http.StatusBadRequest,
+				Message: fmt.Sprintf("%s is not a member of %s", instanceToRemove.Instance, key.String()),
 			}
 		}
+	}
+
+	igAttrs.InstanceMap[*key] = instancesWithNamedPorts
+	return nil
+}
 
-	var attrs instanceGroupAttributes
-	attrs = m.X.(instanceGroupAttributes)
+// List gets a list of InstanceWithNamedPorts
+func (igAttrs *InstanceGroupAttributes) List(key *meta.Key) []*ga.InstanceWithNamedPorts {
+	igAttrs.Lock.Lock()
+	defer igAttrs.Lock.Unlock()
 
-	instances, ok := attrs.instanceMap[*key]
+	instancesWithNamedPorts, ok := igAttrs.InstanceMap[*key]
 	if !ok {
-		instances = []*ga.InstanceWithNamedPorts{}
+		instancesWithNamedPorts = make(map[string]*ga.InstanceWithNamedPorts)
 	}
 
-	for _, instance := range req.Instances {
-		iWithPort := &ga.InstanceWithNamedPorts{
-			Instance: instance.Instance,
+	var instanceList []*ga.InstanceWithNamedPorts
+	for _, val := range instancesWithNamedPorts {
+		instanceList = append(instanceList, val)
 	}
 
-		instances = append(instances, iWithPort)
+	return instanceList
+}
+
+// AddInstancesHook mocks adding instances from an InstanceGroup
+func AddInstancesHook(ctx context.Context, key *meta.Key, req *ga.InstanceGroupsAddInstancesRequest, m *cloud.MockInstanceGroups) error {
+	_, err := m.Get(ctx, key)
+	if err != nil {
+		return &googleapi.Error{
+			Code:    http.StatusNotFound,
+			Message: fmt.Sprintf("Key: %s was not found in InstanceGroups", key.String()),
+		}
 	}
 
-	attrs.instanceMap[*key] = instances
+	var attrs InstanceGroupAttributes
+	attrs = m.X.(InstanceGroupAttributes)
+	attrs.AddInstances(key, req.Instances)
 	m.X = attrs
 	return nil
 }
@@ -280,17 +327,9 @@ func ListInstancesHook(ctx context.Context, key *meta.Key, req *ga.InstanceGroup
 		}
 	}
 
-	if m.X == nil {
-		m.X = instanceGroupAttributes{instanceMap: make(map[meta.Key][]*ga.InstanceWithNamedPorts)}
-	}
-
-	var attrs instanceGroupAttributes
-	attrs = m.X.(instanceGroupAttributes)
-
-	instances, ok := attrs.instanceMap[*key]
-	if !ok {
-		instances = []*ga.InstanceWithNamedPorts{}
-	}
+	var attrs InstanceGroupAttributes
+	attrs = m.X.(InstanceGroupAttributes)
+	instances := attrs.List(key)
 
 	return instances, nil
 }
@@ -305,32 +344,9 @@ func RemoveInstancesHook(ctx context.Context, key *meta.Key, req *ga.InstanceGro
 		}
 	}
 
-	if m.X == nil {
-		m.X = instanceGroupAttributes{
-			instanceMap: make(map[meta.Key][]*ga.InstanceWithNamedPorts),
-		}
-	}
-
-	var attrs instanceGroupAttributes
-	attrs = m.X.(instanceGroupAttributes)
-
-	instances, ok := attrs.instanceMap[*key]
-	if !ok {
-		instances = []*ga.InstanceWithNamedPorts{}
-	}
-
-	for _, instanceToRemove := range req.Instances {
-		for i, instance := range instances {
-			if instanceToRemove.Instance == instance.Instance {
-				// Delete instance from instances without preserving order
-				instances[i] = instances[len(instances)-1]
-				instances = instances[:len(instances)-1]
-				break
-			}
-		}
-	}
-
-	attrs.instanceMap[*key] = instances
+	var attrs InstanceGroupAttributes
+	attrs = m.X.(InstanceGroupAttributes)
+	attrs.RemoveInstances(key, req.Instances)
 	m.X = attrs
 	return nil
 }

pkg/cloudprovider/providers/gce/gce_loadbalancer_utils_test.go

@@ -23,6 +23,7 @@ package gce
 import (
 	"fmt"
 	"net/http"
+	"sync"
 
 	compute "google.golang.org/api/compute/v1"
 
@@ -102,6 +103,10 @@ func fakeGCECloud(vals TestClusterValues) (*GCECloud, error) {
 	c.MockAddresses.InsertHook = mock.InsertAddressHook
 	c.MockAlphaAddresses.InsertHook = mock.InsertAlphaAddressHook
 
+	c.MockInstanceGroups.X = mock.InstanceGroupAttributes{
+		InstanceMap: make(map[meta.Key]map[string]*compute.InstanceWithNamedPorts),
+		Lock:        &sync.Mutex{},
+	}
 	c.MockInstanceGroups.AddInstancesHook = mock.AddInstancesHook
 	c.MockInstanceGroups.RemoveInstancesHook = mock.RemoveInstancesHook
 	c.MockInstanceGroups.ListInstancesHook = mock.ListInstancesHook