Commit e075309b authored by Guoliang Wang's avatar Guoliang Wang

-Remove TODO comment of GetNonzeroRequests function

parent 4344d337
...@@ -32,9 +32,8 @@ const DefaultMilliCPURequest int64 = 100 // 0.1 core ...@@ -32,9 +32,8 @@ const DefaultMilliCPURequest int64 = 100 // 0.1 core
// DefaultMemoryRequest defines default memory request size. // DefaultMemoryRequest defines default memory request size.
const DefaultMemoryRequest int64 = 200 * 1024 * 1024 // 200 MB const DefaultMemoryRequest int64 = 200 * 1024 * 1024 // 200 MB
// GetNonzeroRequests returns the default resource request if none is found or what is provided on the request // GetNonzeroRequests returns the default resource request if none is found or
// TODO: Consider setting default as a fixed fraction of machine capacity (take "capacity v1.ResourceList" // what is provided on the request.
// as an additional argument here) rather than using constants
func GetNonzeroRequests(requests *v1.ResourceList) (int64, int64) { func GetNonzeroRequests(requests *v1.ResourceList) (int64, int64) {
var outMilliCPU, outMemory int64 var outMilliCPU, outMemory int64
// Override if un-set, but not if explicitly set to zero // Override if un-set, but not if explicitly set to zero
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment