fed: Remove flakey and redundant replicaset unit test

federation/pkg/federation-controller/sync/BUILD

@@ -45,7 +45,6 @@ go_test(
     srcs = [
         "controller_test.go",
         "deploymentcontroller_test.go",
-        "replicasetcontroller_test.go",
     ],
     library = ":go_default_library",
     tags = ["automanaged"],
@@ -65,8 +64,6 @@ go_test(
         "//vendor/k8s.io/apimachinery/pkg/runtime:go_default_library",
         "//vendor/k8s.io/apimachinery/pkg/types:go_default_library",
         "//vendor/k8s.io/apimachinery/pkg/util/wait:go_default_library",
-        "//vendor/k8s.io/apimachinery/pkg/watch:go_default_library",
-        "//vendor/k8s.io/client-go/testing:go_default_library",
     ],
 )
 

federation/pkg/federation-controller/sync/replicasetcontroller_test.go

-/*
-Copyright 2016 The Kubernetes Authors.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-    http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
-
-package sync
-
-import (
-	"flag"
-	"fmt"
-	"testing"
-	"time"
-
-	apiv1 "k8s.io/api/core/v1"
-	extensionsv1 "k8s.io/api/extensions/v1beta1"
-	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-	"k8s.io/apimachinery/pkg/watch"
-	core "k8s.io/client-go/testing"
-	fedv1 "k8s.io/kubernetes/federation/apis/federation/v1beta1"
-	fedclientfake "k8s.io/kubernetes/federation/client/clientset_generated/federation_clientset/fake"
-	"k8s.io/kubernetes/federation/pkg/federatedtypes"
-	testutil "k8s.io/kubernetes/federation/pkg/federation-controller/util/test"
-	kubeclientset "k8s.io/kubernetes/pkg/client/clientset_generated/clientset"
-	kubeclientfake "k8s.io/kubernetes/pkg/client/clientset_generated/clientset/fake"
-
-	"github.com/stretchr/testify/assert"
-)
-
-const (
-	pods        = "pods"
-	replicasets = "replicasets"
-	k8s1        = "k8s-1"
-	k8s2        = "k8s-2"
-)
-
-func TestReplicaSetController(t *testing.T) {
-	flag.Set("logtostderr", "true")
-	flag.Set("v", "5")
-	flag.Parse()
-
-	fedclientset := fedclientfake.NewSimpleClientset()
-	fedrswatch := watch.NewFake()
-	fedclientset.PrependWatchReactor(replicasets, core.DefaultWatchReactor(fedrswatch, nil))
-
-	fedclientset.Federation().Clusters().Create(testutil.NewCluster(k8s1, apiv1.ConditionTrue))
-	fedclientset.Federation().Clusters().Create(testutil.NewCluster(k8s2, apiv1.ConditionTrue))
-
-	kube1clientset := kubeclientfake.NewSimpleClientset()
-	kube1rswatch := watch.NewFake()
-	kube1clientset.PrependWatchReactor(replicasets, core.DefaultWatchReactor(kube1rswatch, nil))
-	kube1Podwatch := watch.NewFake()
-	kube1clientset.PrependWatchReactor(pods, core.DefaultWatchReactor(kube1Podwatch, nil))
-	kube2clientset := kubeclientfake.NewSimpleClientset()
-	kube2rswatch := watch.NewFake()
-	kube2clientset.PrependWatchReactor(replicasets, core.DefaultWatchReactor(kube2rswatch, nil))
-	kube2Podwatch := watch.NewFake()
-	kube2clientset.PrependWatchReactor(pods, core.DefaultWatchReactor(kube2Podwatch, nil))
-
-	fedInformerClientFactory := func(cluster *fedv1.Cluster) (kubeclientset.Interface, error) {
-		switch cluster.Name {
-		case k8s1:
-			return kube1clientset, nil
-		case k8s2:
-			return kube2clientset, nil
-		default:
-			return nil, fmt.Errorf("Unknown cluster: %v", cluster.Name)
-		}
-	}
-	replicaSetController := newFederationSyncController(fedclientset, federatedtypes.NewReplicaSetAdapter(fedclientset))
-	replicaSetController.minimizeLatency()
-	rsFedinformer := testutil.ToFederatedInformerForTestOnly(replicaSetController.informer)
-	rsFedinformer.SetClientFactory(fedInformerClientFactory)
-
-	stopChan := make(chan struct{})
-	defer close(stopChan)
-	go replicaSetController.Run(stopChan)
-
-	rs := newReplicaSetWithReplicas("rs", 9)
-	rs, _ = fedclientset.Extensions().ReplicaSets(metav1.NamespaceDefault).Create(rs)
-	fedrswatch.Add(rs)
-	time.Sleep(2 * time.Second)
-
-	rs1, _ := kube1clientset.Extensions().ReplicaSets(metav1.NamespaceDefault).Get(rs.Name, metav1.GetOptions{})
-	kube1rswatch.Add(rs1)
-	rs1.Status.Replicas = *rs1.Spec.Replicas
-	rs1.Status.FullyLabeledReplicas = *rs1.Spec.Replicas
-	rs1.Status.ReadyReplicas = *rs1.Spec.Replicas
-	rs1.Status.AvailableReplicas = *rs1.Spec.Replicas
-	rs1, _ = kube1clientset.Extensions().ReplicaSets(metav1.NamespaceDefault).UpdateStatus(rs1)
-	kube1rswatch.Modify(rs1)
-
-	rs2, _ := kube2clientset.Extensions().ReplicaSets(metav1.NamespaceDefault).Get(rs.Name, metav1.GetOptions{})
-	kube2rswatch.Add(rs2)
-	rs2.Status.Replicas = *rs2.Spec.Replicas
-	rs2.Status.FullyLabeledReplicas = *rs2.Spec.Replicas
-	rs2.Status.ReadyReplicas = *rs2.Spec.Replicas
-	rs2.Status.AvailableReplicas = *rs2.Spec.Replicas
-	rs2, _ = kube2clientset.Extensions().ReplicaSets(metav1.NamespaceDefault).UpdateStatus(rs2)
-	kube2rswatch.Modify(rs2)
-
-	time.Sleep(2 * time.Second)
-	rs, _ = fedclientset.Extensions().ReplicaSets(metav1.NamespaceDefault).Get(rs.Name, metav1.GetOptions{})
-	assert.Equal(t, *rs.Spec.Replicas, *rs1.Spec.Replicas+*rs2.Spec.Replicas)
-	assert.Equal(t, rs.Status.Replicas, rs1.Status.Replicas+rs2.Status.Replicas)
-	assert.Equal(t, rs.Status.FullyLabeledReplicas, rs1.Status.FullyLabeledReplicas+rs2.Status.FullyLabeledReplicas)
-	assert.Equal(t, rs.Status.ReadyReplicas, rs1.Status.ReadyReplicas+rs2.Status.ReadyReplicas)
-	assert.Equal(t, rs.Status.AvailableReplicas, rs1.Status.AvailableReplicas+rs2.Status.AvailableReplicas)
-
-	var replicas int32 = 20
-	rs.Spec.Replicas = &replicas
-	rs, _ = fedclientset.Extensions().ReplicaSets(metav1.NamespaceDefault).Update(rs)
-	fedrswatch.Modify(rs)
-	time.Sleep(2 * time.Second)
-
-	rs1, _ = kube1clientset.Extensions().ReplicaSets(metav1.NamespaceDefault).Get(rs.Name, metav1.GetOptions{})
-	rs1.Status.Replicas = *rs1.Spec.Replicas
-	rs1.Status.FullyLabeledReplicas = *rs1.Spec.Replicas
-	rs1.Status.ReadyReplicas = *rs1.Spec.Replicas
-	rs1.Status.AvailableReplicas = *rs1.Spec.Replicas
-	rs1, _ = kube1clientset.Extensions().ReplicaSets(metav1.NamespaceDefault).UpdateStatus(rs1)
-	kube1rswatch.Modify(rs1)
-
-	rs2, _ = kube2clientset.Extensions().ReplicaSets(metav1.NamespaceDefault).Get(rs.Name, metav1.GetOptions{})
-	rs2.Status.Replicas = *rs2.Spec.Replicas
-	rs2.Status.FullyLabeledReplicas = *rs2.Spec.Replicas
-	rs2.Status.ReadyReplicas = *rs2.Spec.Replicas
-	rs2.Status.AvailableReplicas = *rs2.Spec.Replicas
-	rs2, _ = kube2clientset.Extensions().ReplicaSets(metav1.NamespaceDefault).UpdateStatus(rs2)
-	kube2rswatch.Modify(rs2)
-
-	time.Sleep(1 * time.Second)
-	rs, _ = fedclientset.Extensions().ReplicaSets(metav1.NamespaceDefault).Get(rs.Name, metav1.GetOptions{})
-	assert.Equal(t, *rs.Spec.Replicas, *rs1.Spec.Replicas+*rs2.Spec.Replicas)
-	assert.Equal(t, rs.Status.Replicas, rs1.Status.Replicas+rs2.Status.Replicas)
-	assert.Equal(t, rs.Status.FullyLabeledReplicas, rs1.Status.FullyLabeledReplicas+rs2.Status.FullyLabeledReplicas)
-	assert.Equal(t, rs.Status.ReadyReplicas, rs1.Status.ReadyReplicas+rs2.Status.ReadyReplicas)
-	assert.Equal(t, rs.Status.AvailableReplicas, rs1.Status.AvailableReplicas+rs2.Status.AvailableReplicas)
-}
-
-func newReplicaSetWithReplicas(name string, replicas int32) *extensionsv1.ReplicaSet {
-	return &extensionsv1.ReplicaSet{
-		ObjectMeta: metav1.ObjectMeta{
-			Name:      name,
-			Namespace: metav1.NamespaceDefault,
-			SelfLink:  "/api/v1/namespaces/default/replicasets/name",
-		},
-		Spec: extensionsv1.ReplicaSetSpec{
-			Replicas: &replicas,
-		},
-	}
-}