Skip to content

K
k3s
Commit b7e87917 authored by k8s-merge-robot's avatar k8s-merge-robot Committed by GitHub
Browse files
Options

Merge pull request #29635 from derekwaynecarr/disable_test_namespace_autoprovision

Automatic merge from submit-queue Disable flaky unit test in admission plugin in NamespaceAutoProvision Ref: https://github.com/kubernetes/kubernetes/issues/29473 Disables the test until the full fix is resolved in https://github.com/kubernetes/kubernetes/pull/29634 This admission controller is not in our default set, but is flaking and is a p0. /cc @ncdc @liggitt @hodovska
parents a78c8e16 09c97a2a
Show whitespace changes
Inline Side-by-side
Showing with 27 additions and 27 deletions
plugin/pkg/admission/namespace/autoprovision/admission_test.go
View file @ b7e87917
...@@ -62,33 +62,33 @@ func TestAdmission(t *testing.T) { ...@@ -62,33 +62,33 @@ func TestAdmission(t *testing.T) {
} }
// TestAdmissionNamespaceExists verifies that no client call is made when a namespace already exists // TestAdmissionNamespaceExists verifies that no client call is made when a namespace already exists
func TestAdmissionNamespaceExists(t *testing.T) { // func TestAdmissionNamespaceExists(t *testing.T) {
namespace := "test" // namespace := "test"
mockClient := &fake.Clientset{} // mockClient := &fake.Clientset{}
informerFactory := informers.NewSharedInformerFactory(mockClient, 5*time.Minute) // informerFactory := informers.NewSharedInformerFactory(mockClient, 5*time.Minute)
informerFactory.Namespaces().Informer().GetStore().Add(&api.Namespace{ // informerFactory.Namespaces().Informer().GetStore().Add(&api.Namespace{
ObjectMeta: api.ObjectMeta{Name: namespace}, // ObjectMeta: api.ObjectMeta{Name: namespace},
}) // })
informerFactory.Start(wait.NeverStop) // informerFactory.Start(wait.NeverStop)
handler := &provision{ // handler := &provision{
client: mockClient, // client: mockClient,
informerFactory: informerFactory, // informerFactory: informerFactory,
} // }
pod := api.Pod{ // pod := api.Pod{
ObjectMeta: api.ObjectMeta{Name: "123", Namespace: namespace}, // ObjectMeta: api.ObjectMeta{Name: "123", Namespace: namespace},
Spec: api.PodSpec{ // Spec: api.PodSpec{
Volumes: []api.Volume{{Name: "vol"}}, // Volumes: []api.Volume{{Name: "vol"}},
Containers: []api.Container{{Name: "ctr", Image: "image"}}, // Containers: []api.Container{{Name: "ctr", Image: "image"}},
}, // },
} // }
err := handler.Admit(admission.NewAttributesRecord(&pod, nil, api.Kind("Pod").WithVersion("version"), pod.Namespace, pod.Name, api.Resource("pods").WithVersion("version"), "", admission.Create, nil)) // err := handler.Admit(admission.NewAttributesRecord(&pod, nil, api.Kind("Pod").WithVersion("version"), pod.Namespace, pod.Name, api.Resource("pods").WithVersion("version"), "", admission.Create, nil))
if err != nil { // if err != nil {
t.Errorf("Unexpected error returned from admission handler") // t.Errorf("Unexpected error returned from admission handler")
} // }
if len(mockClient.Actions()) != 0 { // if len(mockClient.Actions()) != 0 {
t.Errorf("No client request should have been made") // t.Errorf("No client request should have been made")
} // }
} // }
// TestIgnoreAdmission validates that a request is ignored if its not a create // TestIgnoreAdmission validates that a request is ignored if its not a create
func TestIgnoreAdmission(t *testing.T) { func TestIgnoreAdmission(t *testing.T) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment