Optionally use a github api token when compiling relase-notes

build/make-release-notes.sh

@@ -24,19 +24,18 @@ function pop_dir {
 }
 
 KUBE_ROOT=$(dirname "${BASH_SOURCE}")/..
+source "${KUBE_ROOT}/hack/lib/init.sh"
 
 if [[ -z "${1:-}" ]]; then
-  echo "Usage: ${0} <pr-number>"
+  echo "Usage: ${0} <pr-number> [opts]"
   exit 1
 fi
 
 pushd . > /dev/null
 trap 'pop_dir' INT TERM EXIT
 
-cd ${KUBE_ROOT}/contrib/release-notes
-# TODO: vendor these dependencies, but using godep again will be annoying...
-GOPATH=$PWD go get github.com/google/go-github/github
-GOPATH=$PWD go get github.com/google/go-querystring/query
-GOPATH=$PWD go build release-notes.go
-./release-notes --last-release-pr=${1}
+kube::golang::build_binaries contrib/release-notes
+kube::golang::place_bins
+releasenotes=$(kube::util::find-binary "release-notes")
+"${releasenotes}" --last-release-pr=${1} ${@}
 

contrib/release-notes/release-notes.go

@@ -18,24 +18,43 @@ package main
 
 import (
 	"bytes"
-	"flag"
 	"fmt"
+	"net/http"
 	"os"
 
 	"github.com/google/go-github/github"
+	flag "github.com/spf13/pflag"
+	"golang.org/x/oauth2"
 )
 
-var target = flag.Int("last-release-pr", 0, "The PR number of the last versioned release.")
+var (
+	target int
+	token  string
+)
+
+func init() {
+	flag.IntVar(&target, "last-release-pr", 0, "The PR number of the last versioned release.")
+	flag.StringVar(&token, "api-token", "", "Github api token for rate limiting. See https://developer.github.com/v3/#rate-limiting.")
+}
 
 func main() {
 	flag.Parse()
 	// Automatically determine this from github.
-	if *target == 0 {
+	if target == 0 {
 		fmt.Printf("--last-release-pr is required.\n")
 		os.Exit(1)
 	}
+	var tc *http.Client
+
+	if len(token) > 0 {
+		tc = oauth2.NewClient(
+			oauth2.NoContext,
+			oauth2.StaticTokenSource(
+				&oauth2.Token{AccessToken: token}),
+		)
+	}
 
-	client := github.NewClient(nil)
+	client := github.NewClient(tc)
 
 	done := false
 
@@ -62,7 +81,7 @@ func main() {
 			if result.MergedAt == nil {
 				continue
 			}
-			if *result.Number == *target {
+			if *result.Number == target {
 				done = true
 				break
 			}