Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
K
k3s
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jacklull
k3s
Commits
b0291f90
Commit
b0291f90
authored
Nov 07, 2017
by
Dr. Stefan Schimanski
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
code-generators: remove distinction of 1st and 2nd comment block for tags
parent
3b4424ce
Show whitespace changes
Inline
Side-by-side
Showing
10 changed files
with
20 additions
and
20 deletions
+20
-20
client_generator.go
...e-generator/cmd/client-gen/generators/client_generator.go
+3
-3
fake_client_generator.go
...r/cmd/client-gen/generators/fake/fake_client_generator.go
+1
-1
generator_fake_for_group.go
...md/client-gen/generators/fake/generator_fake_for_group.go
+1
-1
generator_fake_for_type.go
...cmd/client-gen/generators/fake/generator_fake_for_type.go
+2
-2
generator_for_group.go
...enerator/cmd/client-gen/generators/generator_for_group.go
+1
-1
generator_for_type.go
...generator/cmd/client-gen/generators/generator_for_type.go
+2
-2
informer.go
...io/code-generator/cmd/informer-gen/generators/informer.go
+1
-1
packages.go
...io/code-generator/cmd/informer-gen/generators/packages.go
+4
-4
expansion.go
....io/code-generator/cmd/lister-gen/generators/expansion.go
+1
-1
lister.go
...k8s.io/code-generator/cmd/lister-gen/generators/lister.go
+4
-4
No files found.
staging/src/k8s.io/code-generator/cmd/client-gen/generators/client_generator.go
View file @
b0291f90
...
@@ -163,7 +163,7 @@ func packageForGroup(gv clientgentypes.GroupVersion, typeList []*types.Type, cli
...
@@ -163,7 +163,7 @@ func packageForGroup(gv clientgentypes.GroupVersion, typeList []*types.Type, cli
return
generators
return
generators
},
},
FilterFunc
:
func
(
c
*
generator
.
Context
,
t
*
types
.
Type
)
bool
{
FilterFunc
:
func
(
c
*
generator
.
Context
,
t
*
types
.
Type
)
bool
{
return
util
.
MustParseClientGenTags
(
t
.
SecondClosestCommentLines
)
.
GenerateClient
return
util
.
MustParseClientGenTags
(
append
(
t
.
SecondClosestCommentLines
,
t
.
CommentLines
...
)
)
.
GenerateClient
},
},
}
}
}
}
...
@@ -345,7 +345,7 @@ func Packages(context *generator.Context, arguments *args.GeneratorArgs) generat
...
@@ -345,7 +345,7 @@ func Packages(context *generator.Context, arguments *args.GeneratorArgs) generat
}
else
{
}
else
{
// User has not specified any override for this group version.
// User has not specified any override for this group version.
// filter out types which dont have genclient.
// filter out types which dont have genclient.
if
tags
:=
util
.
MustParseClientGenTags
(
t
.
SecondClosestCommentLines
);
!
tags
.
GenerateClient
{
if
tags
:=
util
.
MustParseClientGenTags
(
append
(
t
.
SecondClosestCommentLines
,
t
.
CommentLines
...
)
);
!
tags
.
GenerateClient
{
continue
continue
}
}
}
}
...
@@ -394,7 +394,7 @@ type tagOverrideNamer struct {
...
@@ -394,7 +394,7 @@ type tagOverrideNamer struct {
}
}
func
(
n
*
tagOverrideNamer
)
Name
(
t
*
types
.
Type
)
string
{
func
(
n
*
tagOverrideNamer
)
Name
(
t
*
types
.
Type
)
string
{
if
nameOverride
:=
extractTag
(
n
.
tagName
,
t
.
SecondClosestCommentLines
);
nameOverride
!=
""
{
if
nameOverride
:=
extractTag
(
n
.
tagName
,
append
(
t
.
SecondClosestCommentLines
,
t
.
CommentLines
...
)
);
nameOverride
!=
""
{
return
nameOverride
return
nameOverride
}
}
...
...
staging/src/k8s.io/code-generator/cmd/client-gen/generators/fake/fake_client_generator.go
View file @
b0291f90
...
@@ -79,7 +79,7 @@ func PackageForGroup(gv clientgentypes.GroupVersion, typeList []*types.Type, cli
...
@@ -79,7 +79,7 @@ func PackageForGroup(gv clientgentypes.GroupVersion, typeList []*types.Type, cli
return
generators
return
generators
},
},
FilterFunc
:
func
(
c
*
generator
.
Context
,
t
*
types
.
Type
)
bool
{
FilterFunc
:
func
(
c
*
generator
.
Context
,
t
*
types
.
Type
)
bool
{
return
util
.
MustParseClientGenTags
(
t
.
SecondClosestCommentLines
)
.
GenerateClient
return
util
.
MustParseClientGenTags
(
append
(
t
.
SecondClosestCommentLines
,
t
.
CommentLines
...
)
)
.
GenerateClient
},
},
}
}
}
}
...
...
staging/src/k8s.io/code-generator/cmd/client-gen/generators/fake/generator_fake_for_group.go
View file @
b0291f90
...
@@ -73,7 +73,7 @@ func (g *genFakeForGroup) GenerateType(c *generator.Context, t *types.Type, w io
...
@@ -73,7 +73,7 @@ func (g *genFakeForGroup) GenerateType(c *generator.Context, t *types.Type, w io
sw
.
Do
(
groupClientTemplate
,
m
)
sw
.
Do
(
groupClientTemplate
,
m
)
for
_
,
t
:=
range
g
.
types
{
for
_
,
t
:=
range
g
.
types
{
tags
,
err
:=
util
.
ParseClientGenTags
(
t
.
SecondClosestCommentLines
)
tags
,
err
:=
util
.
ParseClientGenTags
(
append
(
t
.
SecondClosestCommentLines
,
t
.
CommentLines
...
)
)
if
err
!=
nil
{
if
err
!=
nil
{
return
err
return
err
}
}
...
...
staging/src/k8s.io/code-generator/cmd/client-gen/generators/fake/generator_fake_for_type.go
View file @
b0291f90
...
@@ -69,7 +69,7 @@ func genStatus(t *types.Type) bool {
...
@@ -69,7 +69,7 @@ func genStatus(t *types.Type) bool {
}
}
}
}
tags
:=
util
.
MustParseClientGenTags
(
t
.
SecondClosestCommentLines
)
tags
:=
util
.
MustParseClientGenTags
(
append
(
t
.
SecondClosestCommentLines
,
t
.
CommentLines
...
)
)
return
hasStatus
&&
!
tags
.
NoStatus
return
hasStatus
&&
!
tags
.
NoStatus
}
}
...
@@ -87,7 +87,7 @@ func hasObjectMeta(t *types.Type) bool {
...
@@ -87,7 +87,7 @@ func hasObjectMeta(t *types.Type) bool {
func
(
g
*
genFakeForType
)
GenerateType
(
c
*
generator
.
Context
,
t
*
types
.
Type
,
w
io
.
Writer
)
error
{
func
(
g
*
genFakeForType
)
GenerateType
(
c
*
generator
.
Context
,
t
*
types
.
Type
,
w
io
.
Writer
)
error
{
sw
:=
generator
.
NewSnippetWriter
(
w
,
c
,
"$"
,
"$"
)
sw
:=
generator
.
NewSnippetWriter
(
w
,
c
,
"$"
,
"$"
)
pkg
:=
filepath
.
Base
(
t
.
Name
.
Package
)
pkg
:=
filepath
.
Base
(
t
.
Name
.
Package
)
tags
,
err
:=
util
.
ParseClientGenTags
(
t
.
SecondClosestCommentLines
)
tags
,
err
:=
util
.
ParseClientGenTags
(
append
(
t
.
SecondClosestCommentLines
,
t
.
CommentLines
...
)
)
if
err
!=
nil
{
if
err
!=
nil
{
return
err
return
err
}
}
...
...
staging/src/k8s.io/code-generator/cmd/client-gen/generators/generator_for_group.go
View file @
b0291f90
...
@@ -105,7 +105,7 @@ func (g *genGroup) GenerateType(c *generator.Context, t *types.Type, w io.Writer
...
@@ -105,7 +105,7 @@ func (g *genGroup) GenerateType(c *generator.Context, t *types.Type, w io.Writer
sw
.
Do
(
groupInterfaceTemplate
,
m
)
sw
.
Do
(
groupInterfaceTemplate
,
m
)
sw
.
Do
(
groupClientTemplate
,
m
)
sw
.
Do
(
groupClientTemplate
,
m
)
for
_
,
t
:=
range
g
.
types
{
for
_
,
t
:=
range
g
.
types
{
tags
,
err
:=
util
.
ParseClientGenTags
(
t
.
SecondClosestCommentLines
)
tags
,
err
:=
util
.
ParseClientGenTags
(
append
(
t
.
SecondClosestCommentLines
,
t
.
CommentLines
...
)
)
if
err
!=
nil
{
if
err
!=
nil
{
return
err
return
err
}
}
...
...
staging/src/k8s.io/code-generator/cmd/client-gen/generators/generator_for_type.go
View file @
b0291f90
...
@@ -67,14 +67,14 @@ func genStatus(t *types.Type) bool {
...
@@ -67,14 +67,14 @@ func genStatus(t *types.Type) bool {
break
break
}
}
}
}
return
hasStatus
&&
!
util
.
MustParseClientGenTags
(
t
.
SecondClosestCommentLines
)
.
NoStatus
return
hasStatus
&&
!
util
.
MustParseClientGenTags
(
append
(
t
.
SecondClosestCommentLines
,
t
.
CommentLines
...
)
)
.
NoStatus
}
}
// GenerateType makes the body of a file implementing the individual typed client for type t.
// GenerateType makes the body of a file implementing the individual typed client for type t.
func
(
g
*
genClientForType
)
GenerateType
(
c
*
generator
.
Context
,
t
*
types
.
Type
,
w
io
.
Writer
)
error
{
func
(
g
*
genClientForType
)
GenerateType
(
c
*
generator
.
Context
,
t
*
types
.
Type
,
w
io
.
Writer
)
error
{
sw
:=
generator
.
NewSnippetWriter
(
w
,
c
,
"$"
,
"$"
)
sw
:=
generator
.
NewSnippetWriter
(
w
,
c
,
"$"
,
"$"
)
pkg
:=
filepath
.
Base
(
t
.
Name
.
Package
)
pkg
:=
filepath
.
Base
(
t
.
Name
.
Package
)
tags
,
err
:=
util
.
ParseClientGenTags
(
t
.
SecondClosestCommentLines
)
tags
,
err
:=
util
.
ParseClientGenTags
(
append
(
t
.
SecondClosestCommentLines
,
t
.
CommentLines
...
)
)
if
err
!=
nil
{
if
err
!=
nil
{
return
err
return
err
}
}
...
...
staging/src/k8s.io/code-generator/cmd/informer-gen/generators/informer.go
View file @
b0291f90
...
@@ -72,7 +72,7 @@ func (g *informerGenerator) GenerateType(c *generator.Context, t *types.Type, w
...
@@ -72,7 +72,7 @@ func (g *informerGenerator) GenerateType(c *generator.Context, t *types.Type, w
clientSetInterface
:=
c
.
Universe
.
Type
(
types
.
Name
{
Package
:
g
.
clientSetPackage
,
Name
:
"Interface"
})
clientSetInterface
:=
c
.
Universe
.
Type
(
types
.
Name
{
Package
:
g
.
clientSetPackage
,
Name
:
"Interface"
})
informerFor
:=
"InformerFor"
informerFor
:=
"InformerFor"
tags
,
err
:=
util
.
ParseClientGenTags
(
t
.
SecondClosestCommentLines
)
tags
,
err
:=
util
.
ParseClientGenTags
(
append
(
t
.
SecondClosestCommentLines
,
t
.
CommentLines
...
)
)
if
err
!=
nil
{
if
err
!=
nil
{
return
err
return
err
}
}
...
...
staging/src/k8s.io/code-generator/cmd/informer-gen/generators/packages.go
View file @
b0291f90
...
@@ -71,7 +71,7 @@ func generatedBy() string {
...
@@ -71,7 +71,7 @@ func generatedBy() string {
func
objectMetaForPackage
(
p
*
types
.
Package
)
(
*
types
.
Type
,
bool
,
error
)
{
func
objectMetaForPackage
(
p
*
types
.
Package
)
(
*
types
.
Type
,
bool
,
error
)
{
generatingForPackage
:=
false
generatingForPackage
:=
false
for
_
,
t
:=
range
p
.
Types
{
for
_
,
t
:=
range
p
.
Types
{
if
!
util
.
MustParseClientGenTags
(
t
.
SecondClosestCommentLines
)
.
GenerateClient
{
if
!
util
.
MustParseClientGenTags
(
append
(
t
.
SecondClosestCommentLines
,
t
.
CommentLines
...
)
)
.
GenerateClient
{
continue
continue
}
}
generatingForPackage
=
true
generatingForPackage
=
true
...
@@ -176,7 +176,7 @@ func Packages(context *generator.Context, arguments *args.GeneratorArgs) generat
...
@@ -176,7 +176,7 @@ func Packages(context *generator.Context, arguments *args.GeneratorArgs) generat
var
typesToGenerate
[]
*
types
.
Type
var
typesToGenerate
[]
*
types
.
Type
for
_
,
t
:=
range
p
.
Types
{
for
_
,
t
:=
range
p
.
Types
{
tags
:=
util
.
MustParseClientGenTags
(
t
.
SecondClosestCommentLines
)
tags
:=
util
.
MustParseClientGenTags
(
append
(
t
.
SecondClosestCommentLines
,
t
.
CommentLines
...
)
)
if
!
tags
.
GenerateClient
||
tags
.
NoVerbs
||
!
tags
.
HasVerb
(
"list"
)
||
!
tags
.
HasVerb
(
"watch"
)
{
if
!
tags
.
GenerateClient
||
tags
.
NoVerbs
||
!
tags
.
HasVerb
(
"list"
)
||
!
tags
.
HasVerb
(
"watch"
)
{
continue
continue
}
}
...
@@ -306,7 +306,7 @@ func groupPackage(basePackage string, groupPkgName string, groupVersions clientg
...
@@ -306,7 +306,7 @@ func groupPackage(basePackage string, groupPkgName string, groupVersions clientg
return
generators
return
generators
},
},
FilterFunc
:
func
(
c
*
generator
.
Context
,
t
*
types
.
Type
)
bool
{
FilterFunc
:
func
(
c
*
generator
.
Context
,
t
*
types
.
Type
)
bool
{
tags
:=
util
.
MustParseClientGenTags
(
t
.
SecondClosestCommentLines
)
tags
:=
util
.
MustParseClientGenTags
(
append
(
t
.
SecondClosestCommentLines
,
t
.
CommentLines
...
)
)
return
tags
.
GenerateClient
&&
tags
.
HasVerb
(
"list"
)
&&
tags
.
HasVerb
(
"watch"
)
return
tags
.
GenerateClient
&&
tags
.
HasVerb
(
"list"
)
&&
tags
.
HasVerb
(
"watch"
)
},
},
}
}
...
@@ -349,7 +349,7 @@ func versionPackage(basePackage string, groupPkgName string, gv clientgentypes.G
...
@@ -349,7 +349,7 @@ func versionPackage(basePackage string, groupPkgName string, gv clientgentypes.G
return
generators
return
generators
},
},
FilterFunc
:
func
(
c
*
generator
.
Context
,
t
*
types
.
Type
)
bool
{
FilterFunc
:
func
(
c
*
generator
.
Context
,
t
*
types
.
Type
)
bool
{
tags
:=
util
.
MustParseClientGenTags
(
t
.
SecondClosestCommentLines
)
tags
:=
util
.
MustParseClientGenTags
(
append
(
t
.
SecondClosestCommentLines
,
t
.
CommentLines
...
)
)
return
tags
.
GenerateClient
&&
tags
.
HasVerb
(
"list"
)
&&
tags
.
HasVerb
(
"watch"
)
return
tags
.
GenerateClient
&&
tags
.
HasVerb
(
"list"
)
&&
tags
.
HasVerb
(
"watch"
)
},
},
}
}
...
...
staging/src/k8s.io/code-generator/cmd/lister-gen/generators/expansion.go
View file @
b0291f90
...
@@ -43,7 +43,7 @@ func (g *expansionGenerator) Filter(c *generator.Context, t *types.Type) bool {
...
@@ -43,7 +43,7 @@ func (g *expansionGenerator) Filter(c *generator.Context, t *types.Type) bool {
func
(
g
*
expansionGenerator
)
GenerateType
(
c
*
generator
.
Context
,
t
*
types
.
Type
,
w
io
.
Writer
)
error
{
func
(
g
*
expansionGenerator
)
GenerateType
(
c
*
generator
.
Context
,
t
*
types
.
Type
,
w
io
.
Writer
)
error
{
sw
:=
generator
.
NewSnippetWriter
(
w
,
c
,
"$"
,
"$"
)
sw
:=
generator
.
NewSnippetWriter
(
w
,
c
,
"$"
,
"$"
)
for
_
,
t
:=
range
g
.
types
{
for
_
,
t
:=
range
g
.
types
{
tags
:=
util
.
MustParseClientGenTags
(
t
.
SecondClosestCommentLines
)
tags
:=
util
.
MustParseClientGenTags
(
append
(
t
.
SecondClosestCommentLines
,
t
.
CommentLines
...
)
)
if
_
,
err
:=
os
.
Stat
(
filepath
.
Join
(
g
.
packagePath
,
strings
.
ToLower
(
t
.
Name
.
Name
+
"_expansion.go"
)));
os
.
IsNotExist
(
err
)
{
if
_
,
err
:=
os
.
Stat
(
filepath
.
Join
(
g
.
packagePath
,
strings
.
ToLower
(
t
.
Name
.
Name
+
"_expansion.go"
)));
os
.
IsNotExist
(
err
)
{
sw
.
Do
(
expansionInterfaceTemplate
,
t
)
sw
.
Do
(
expansionInterfaceTemplate
,
t
)
if
!
tags
.
NonNamespaced
{
if
!
tags
.
NonNamespaced
{
...
...
staging/src/k8s.io/code-generator/cmd/lister-gen/generators/lister.go
View file @
b0291f90
...
@@ -118,7 +118,7 @@ func Packages(context *generator.Context, arguments *args.GeneratorArgs) generat
...
@@ -118,7 +118,7 @@ func Packages(context *generator.Context, arguments *args.GeneratorArgs) generat
var
typesToGenerate
[]
*
types
.
Type
var
typesToGenerate
[]
*
types
.
Type
for
_
,
t
:=
range
p
.
Types
{
for
_
,
t
:=
range
p
.
Types
{
tags
:=
util
.
MustParseClientGenTags
(
t
.
SecondClosestCommentLines
)
tags
:=
util
.
MustParseClientGenTags
(
append
(
t
.
SecondClosestCommentLines
,
t
.
CommentLines
...
)
)
if
!
tags
.
GenerateClient
||
!
tags
.
HasVerb
(
"list"
)
||
!
tags
.
HasVerb
(
"get"
)
{
if
!
tags
.
GenerateClient
||
!
tags
.
HasVerb
(
"list"
)
||
!
tags
.
HasVerb
(
"get"
)
{
continue
continue
}
}
...
@@ -160,7 +160,7 @@ func Packages(context *generator.Context, arguments *args.GeneratorArgs) generat
...
@@ -160,7 +160,7 @@ func Packages(context *generator.Context, arguments *args.GeneratorArgs) generat
return
generators
return
generators
},
},
FilterFunc
:
func
(
c
*
generator
.
Context
,
t
*
types
.
Type
)
bool
{
FilterFunc
:
func
(
c
*
generator
.
Context
,
t
*
types
.
Type
)
bool
{
tags
:=
util
.
MustParseClientGenTags
(
t
.
SecondClosestCommentLines
)
tags
:=
util
.
MustParseClientGenTags
(
append
(
t
.
SecondClosestCommentLines
,
t
.
CommentLines
...
)
)
return
tags
.
GenerateClient
&&
tags
.
HasVerb
(
"list"
)
&&
tags
.
HasVerb
(
"get"
)
return
tags
.
GenerateClient
&&
tags
.
HasVerb
(
"list"
)
&&
tags
.
HasVerb
(
"get"
)
},
},
})
})
...
@@ -174,7 +174,7 @@ func objectMetaForPackage(p *types.Package) (*types.Type, bool, error) {
...
@@ -174,7 +174,7 @@ func objectMetaForPackage(p *types.Package) (*types.Type, bool, error) {
generatingForPackage
:=
false
generatingForPackage
:=
false
for
_
,
t
:=
range
p
.
Types
{
for
_
,
t
:=
range
p
.
Types
{
// filter out types which dont have genclient.
// filter out types which dont have genclient.
if
!
util
.
MustParseClientGenTags
(
t
.
SecondClosestCommentLines
)
.
GenerateClient
{
if
!
util
.
MustParseClientGenTags
(
append
(
t
.
SecondClosestCommentLines
,
t
.
CommentLines
...
)
)
.
GenerateClient
{
continue
continue
}
}
generatingForPackage
=
true
generatingForPackage
=
true
...
@@ -238,7 +238,7 @@ func (g *listerGenerator) GenerateType(c *generator.Context, t *types.Type, w io
...
@@ -238,7 +238,7 @@ func (g *listerGenerator) GenerateType(c *generator.Context, t *types.Type, w io
"objectMeta"
:
g
.
objectMeta
,
"objectMeta"
:
g
.
objectMeta
,
}
}
tags
,
err
:=
util
.
ParseClientGenTags
(
t
.
SecondClosestCommentLines
)
tags
,
err
:=
util
.
ParseClientGenTags
(
append
(
t
.
SecondClosestCommentLines
,
t
.
CommentLines
...
)
)
if
err
!=
nil
{
if
err
!=
nil
{
return
err
return
err
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment