Commit aa1d47a3 authored by Shimin Guo's avatar Shimin Guo

Fix premature return

parent e3c24829
...@@ -1138,7 +1138,7 @@ func mergePatchIntoOriginal(original, patch map[string]interface{}, t reflect.Ty ...@@ -1138,7 +1138,7 @@ func mergePatchIntoOriginal(original, patch map[string]interface{}, t reflect.Ty
return err return err
} }
case !foundOriginal && !foundPatch: case !foundOriginal && !foundPatch:
return nil continue
} }
// Split all items into patch items and server-only items and then enforce the order. // Split all items into patch items and server-only items and then enforce the order.
......
...@@ -5969,6 +5969,75 @@ retainKeysMergingList: ...@@ -5969,6 +5969,75 @@ retainKeysMergingList:
`), `),
}, },
}, },
{
Description: "delete and reorder in one list, reorder in another",
StrategicMergePatchRawTestCaseData: StrategicMergePatchRawTestCaseData{
Original: []byte(`
mergingList:
- name: a
value: a
- name: b
value: b
mergeItemPtr:
- name: c
value: c
- name: d
value: d
`),
Current: []byte(`
mergingList:
- name: a
value: a
- name: b
value: b
mergeItemPtr:
- name: c
value: c
- name: d
value: d
`),
Modified: []byte(`
mergingList:
- name: b
value: b
mergeItemPtr:
- name: d
value: d
- name: c
value: c
`),
TwoWay: []byte(`
$setElementOrder/mergingList:
- name: b
$setElementOrder/mergeItemPtr:
- name: d
- name: c
mergingList:
- $patch: delete
name: a
`),
ThreeWay: []byte(`
$setElementOrder/mergingList:
- name: b
$setElementOrder/mergeItemPtr:
- name: d
- name: c
mergingList:
- $patch: delete
name: a
`),
Result: []byte(`
mergingList:
- name: b
value: b
mergeItemPtr:
- name: d
value: d
- name: c
value: c
`),
},
},
} }
func TestStrategicMergePatch(t *testing.T) { func TestStrategicMergePatch(t *testing.T) {
...@@ -5993,10 +6062,13 @@ func TestStrategicMergePatch(t *testing.T) { ...@@ -5993,10 +6062,13 @@ func TestStrategicMergePatch(t *testing.T) {
testThreeWayPatch(t, c) testThreeWayPatch(t, c)
} }
// run multiple times to exercise different map traversal orders
for i := 0; i < 10; i++ {
for _, c := range strategicMergePatchRawTestCases { for _, c := range strategicMergePatchRawTestCases {
testTwoWayPatchForRawTestCase(t, c) testTwoWayPatchForRawTestCase(t, c)
testThreeWayPatchForRawTestCase(t, c) testThreeWayPatchForRawTestCase(t, c)
} }
}
} }
func testStrategicMergePatchWithCustomArguments(t *testing.T, description, original, patch string, dataStruct interface{}, err error) { func testStrategicMergePatchWithCustomArguments(t *testing.T, description, original, patch string, dataStruct interface{}, err error) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment