Unverified Commit 9fb4a2aa authored by k8s-ci-robot's avatar k8s-ci-robot Committed by GitHub

Merge pull request #70060 from pbarker/audit-webhook

updates shared apiserver webhook client
parents 1af393d5 5874a1f8
...@@ -66,14 +66,14 @@ func NewClientManager(gv schema.GroupVersion, addToSchemaFunc func(s *runtime.Sc ...@@ -66,14 +66,14 @@ func NewClientManager(gv schema.GroupVersion, addToSchemaFunc func(s *runtime.Sc
if err != nil { if err != nil {
return ClientManager{}, err return ClientManager{}, err
} }
admissionScheme := runtime.NewScheme() hookScheme := runtime.NewScheme()
if err := addToSchemaFunc(admissionScheme); err != nil { if err := addToSchemaFunc(hookScheme); err != nil {
return ClientManager{}, err return ClientManager{}, err
} }
return ClientManager{ return ClientManager{
cache: cache, cache: cache,
negotiatedSerializer: serializer.NegotiatedSerializerWrapper(runtime.SerializerInfo{ negotiatedSerializer: serializer.NegotiatedSerializerWrapper(runtime.SerializerInfo{
Serializer: serializer.NewCodecFactory(admissionScheme).LegacyCodec(gv), Serializer: serializer.NewCodecFactory(hookScheme).LegacyCodec(gv),
}), }),
}, nil }, nil
} }
......
...@@ -28,7 +28,7 @@ type ErrCallingWebhook struct { ...@@ -28,7 +28,7 @@ type ErrCallingWebhook struct {
func (e *ErrCallingWebhook) Error() string { func (e *ErrCallingWebhook) Error() string {
if e.Reason != nil { if e.Reason != nil {
return fmt.Sprintf("failed calling admission webhook %q: %v", e.WebhookName, e.Reason) return fmt.Sprintf("failed calling webhook %q: %v", e.WebhookName, e.Reason)
} }
return fmt.Sprintf("failed calling admission webhook %q; no further details available", e.WebhookName) return fmt.Sprintf("failed calling webhook %q; no further details available", e.WebhookName)
} }
...@@ -37,7 +37,7 @@ const defaultRequestTimeout = 30 * time.Second ...@@ -37,7 +37,7 @@ const defaultRequestTimeout = 30 * time.Second
type GenericWebhook struct { type GenericWebhook struct {
RestClient *rest.RESTClient RestClient *rest.RESTClient
initialBackoff time.Duration InitialBackoff time.Duration
} }
// NewGenericWebhook creates a new GenericWebhook from the provided kubeconfig file. // NewGenericWebhook creates a new GenericWebhook from the provided kubeconfig file.
...@@ -83,7 +83,7 @@ func newGenericWebhook(scheme *runtime.Scheme, codecFactory serializer.CodecFact ...@@ -83,7 +83,7 @@ func newGenericWebhook(scheme *runtime.Scheme, codecFactory serializer.CodecFact
// it returns an error for which apierrors.SuggestsClientDelay() or apierrors.IsInternalError() returns true. // it returns an error for which apierrors.SuggestsClientDelay() or apierrors.IsInternalError() returns true.
func (g *GenericWebhook) WithExponentialBackoff(webhookFn func() rest.Result) rest.Result { func (g *GenericWebhook) WithExponentialBackoff(webhookFn func() rest.Result) rest.Result {
var result rest.Result var result rest.Result
WithExponentialBackoff(g.initialBackoff, func() error { WithExponentialBackoff(g.InitialBackoff, func() error {
result = webhookFn() result = webhookFn()
return result.Error() return result.Error()
}) })
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment