Merge pull request #18331 from janetkuo/fix-deployment-getnewrc

Fix bug when getting new RC of a deployment

Merge pull request #18331 from janetkuo/fix-deployment-getnewrc
9d1f07da · Nikhil Jindal · b9aa7108 · 72bd4e8c · 9d1f07da
Commit 9d1f07da authored Dec 10, 2015 by Nikhil Jindal
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 3 deletions

deployment.go pkg/util/deployment/deployment.go +3 -3

No files found.
--- a/pkg/util/deployment/deployment.go
+++ b/pkg/util/deployment/deployment.go
@@ -77,10 +77,10 @@ func GetNewRC(deployment extensions.Deployment, c client.Interface) (*api.Replic
 	}
 	newRCTemplate := GetNewRCTemplate(deployment)
-	for _, rc := range rcList.Items {
+	for i := range rcList.Items {
-		if api.Semantic.DeepEqual(rc.Spec.Template, &newRCTemplate) {
+		if api.Semantic.DeepEqual(rcList.Items[i].Spec.Template, &newRCTemplate) {
 			// This is the new RC.
-			return &rc, nil
+			return &rcList.Items[i], nil
 		}
 	}
 	// new RC does not exist.