Merge pull request #75861 from shinytang6/enhance/cleanup-scheduler

scheduler: handle err and remove useless assignment

Merge pull request #75861 from shinytang6/enhance/cleanup-scheduler
9a5b7b84 · Kubernetes Prow Robot · GitHub · 78981879 · 86515d8b · 9a5b7b84
Unverified Commit 9a5b7b84 authored Mar 29, 2019 by Kubernetes Prow Robot Committed by GitHub Mar 29, 2019
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

scheduler.go pkg/scheduler/scheduler.go +3 -1

No files found.
--- a/pkg/scheduler/scheduler.go
+++ b/pkg/scheduler/scheduler.go
@@ -542,7 +542,9 @@ func (sched *Scheduler) scheduleOne() {
 				metrics.PodScheduleErrors.Inc()
 			}
 			if !approved {
-				sched.Cache().ForgetPod(assumedPod)
+				if forgetErr := sched.Cache().ForgetPod(assumedPod); forgetErr != nil {
+					klog.Errorf("scheduler cache ForgetPod failed: %v", forgetErr)
+				}
 				var reason string
 				if err == nil {
 					msg := fmt.Sprintf("prebind plugin %v rejected pod %v.", pl.Name(), assumedPod.Name)