Commit 98c7fe98 authored by bprashanth's avatar bprashanth

Don't eat 403 in service controller

parent cbbe421d
...@@ -324,12 +324,10 @@ func (s *ServiceController) persistUpdate(service *v1.Service) error { ...@@ -324,12 +324,10 @@ func (s *ServiceController) persistUpdate(service *v1.Service) error {
return nil return nil
} }
// TODO: Try to resolve the conflict if the change was unrelated to load // TODO: Try to resolve the conflict if the change was unrelated to load
// balancer status. For now, just rely on the fact that we'll // balancer status. For now, just pass it up the stack.
// also process the update that caused the resource version to change.
if errors.IsConflict(err) { if errors.IsConflict(err) {
glog.Warningf("Not persisting update to service '%s/%s' that has been changed since we received it: %v", return fmt.Errorf("Not persisting update to service '%s/%s' that has been changed since we received it: %v",
service.Namespace, service.Name, err) service.Namespace, service.Name, err)
return nil
} }
glog.Warningf("Failed to persist updated LoadBalancerStatus to service '%s/%s' after creating its load balancer: %v", glog.Warningf("Failed to persist updated LoadBalancerStatus to service '%s/%s' after creating its load balancer: %v",
service.Namespace, service.Name, err) service.Namespace, service.Name, err)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment