Commit 8c188b2b authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub

Merge pull request #45157 from k82cn/rm_rc_comments

Automatic merge from submit-queue Removed TODO that renaming ReplicationManager. **What this PR does / why we need it**: Updated comments to avoid potential PRs on renaming. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # N/A **Release note**: ```release-note-none ```
parents a8e94004 c55f30ba
...@@ -61,8 +61,8 @@ var controllerKind = v1.SchemeGroupVersion.WithKind("ReplicationController") ...@@ -61,8 +61,8 @@ var controllerKind = v1.SchemeGroupVersion.WithKind("ReplicationController")
// ReplicationManager is responsible for synchronizing ReplicationController objects stored // ReplicationManager is responsible for synchronizing ReplicationController objects stored
// in the system with actual running pods. // in the system with actual running pods.
// TODO: this really should be called ReplicationController. The only reason why it's a Manager // NOTE: using this name to distinguish this type from API object "ReplicationController"; will
// is to distinguish this type from API object "ReplicationController". We should fix this. // not fix it right now. Refer to #41459 for more detail.
type ReplicationManager struct { type ReplicationManager struct {
kubeClient clientset.Interface kubeClient clientset.Interface
podControl controller.PodControlInterface podControl controller.PodControlInterface
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment