kubeadm: preflight should only warn about unresolvable hostnames

This is quite often the case on AWS, and we really don't care if the hostname is resolvable or not. It's not an easy problem to ask user to fix, and there is no functional penalty at the Kubernetes level, also it's possible that users fixes their host resolution eventually, we don't have to make them do so.

kubeadm: preflight should only warn about unresolvable hostnames
829c47f9 · Ilya Dmitrichenko · e1720af7 · 829c47f9
Unverified Commit 829c47f9 authored Feb 09, 2017 by Ilya Dmitrichenko
Show whitespace changes
Inline Side-by-side

Showing with 4 additions and 3 deletions

checks.go cmd/kubeadm/app/preflight/checks.go +4 -3

No files found.
--- a/cmd/kubeadm/app/preflight/checks.go
+++ b/cmd/kubeadm/app/preflight/checks.go
@@ -239,18 +239,19 @@ type HostnameCheck struct{}
 func (hc HostnameCheck) Check() (warnings, errors []error) {
 	errors = []error{}
+	warnings = []error{}
 	hostname := node.GetHostname("")
 	for _, msg := range validation.ValidateNodeName(hostname, false) {
 		errors = append(errors, fmt.Errorf("hostname \"%s\" %s", hostname, msg))
 	}
 	addr, err := net.LookupHost(hostname)
 	if addr == nil {
-		errors = append(errors, fmt.Errorf("hostname \"%s\" could not be reached", hostname))
+		warnings = append(warnings, fmt.Errorf("hostname \"%s\" could not be reached", hostname))
 	}
 	if err != nil {
-		errors = append(errors, fmt.Errorf("hostname \"%s\" %s", hostname, err))
+		warnings = append(warnings, fmt.Errorf("hostname \"%s\" %s", hostname, err))
 	}
-	return nil, errors
+	return warnings, errors
 }
 // HTTPProxyCheck checks if https connection to specific host is going