Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
K
k3s
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jacklull
k3s
Commits
5c94d422
Commit
5c94d422
authored
Apr 13, 2017
by
Kubernetes Submit Queue
Committed by
GitHub
Apr 13, 2017
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #44378 from FengyunPan/update-federation-event
Automatic merge from submit-queue Use EventTypeWarning instead of EventTypeNormal when failure
parents
c814bab9
0845bd38
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
5 additions
and
5 deletions
+5
-5
configmap_controller.go
...g/federation-controller/configmap/configmap_controller.go
+2
-2
secret_controller.go
...ion/pkg/federation-controller/secret/secret_controller.go
+2
-2
deletion_helper.go
...eration-controller/util/deletionhelper/deletion_helper.go
+1
-1
No files found.
federation/pkg/federation-controller/configmap/configmap_controller.go
View file @
5c94d422
...
@@ -335,7 +335,7 @@ func (configmapcontroller *ConfigMapController) reconcileConfigMap(configmap typ
...
@@ -335,7 +335,7 @@ func (configmapcontroller *ConfigMapController) reconcileConfigMap(configmap typ
if
configMap
.
DeletionTimestamp
!=
nil
{
if
configMap
.
DeletionTimestamp
!=
nil
{
if
err
:=
configmapcontroller
.
delete
(
configMap
);
err
!=
nil
{
if
err
:=
configmapcontroller
.
delete
(
configMap
);
err
!=
nil
{
glog
.
Errorf
(
"Failed to delete %s: %v"
,
configmap
,
err
)
glog
.
Errorf
(
"Failed to delete %s: %v"
,
configmap
,
err
)
configmapcontroller
.
eventRecorder
.
Eventf
(
configMap
,
api
.
EventType
Normal
,
"DeleteFailed"
,
configmapcontroller
.
eventRecorder
.
Eventf
(
configMap
,
api
.
EventType
Warning
,
"DeleteFailed"
,
"ConfigMap delete failed: %v"
,
err
)
"ConfigMap delete failed: %v"
,
err
)
configmapcontroller
.
deliverConfigMap
(
configmap
,
0
,
true
)
configmapcontroller
.
deliverConfigMap
(
configmap
,
0
,
true
)
}
}
...
@@ -410,7 +410,7 @@ func (configmapcontroller *ConfigMapController) reconcileConfigMap(configmap typ
...
@@ -410,7 +410,7 @@ func (configmapcontroller *ConfigMapController) reconcileConfigMap(configmap typ
}
}
err
=
configmapcontroller
.
federatedUpdater
.
UpdateWithOnError
(
operations
,
configmapcontroller
.
updateTimeout
,
err
=
configmapcontroller
.
federatedUpdater
.
UpdateWithOnError
(
operations
,
configmapcontroller
.
updateTimeout
,
func
(
op
util
.
FederatedOperation
,
operror
error
)
{
func
(
op
util
.
FederatedOperation
,
operror
error
)
{
configmapcontroller
.
eventRecorder
.
Eventf
(
configMap
,
api
.
EventType
Normal
,
"UpdateInClusterFailed"
,
configmapcontroller
.
eventRecorder
.
Eventf
(
configMap
,
api
.
EventType
Warning
,
"UpdateInClusterFailed"
,
"ConfigMap update in cluster %s failed: %v"
,
op
.
ClusterName
,
operror
)
"ConfigMap update in cluster %s failed: %v"
,
op
.
ClusterName
,
operror
)
})
})
...
...
federation/pkg/federation-controller/secret/secret_controller.go
View file @
5c94d422
...
@@ -372,7 +372,7 @@ func (s *FederationSyncController) reconcile(namespacedName types.NamespacedName
...
@@ -372,7 +372,7 @@ func (s *FederationSyncController) reconcile(namespacedName types.NamespacedName
if
meta
.
DeletionTimestamp
!=
nil
{
if
meta
.
DeletionTimestamp
!=
nil
{
if
err
:=
s
.
delete
(
obj
,
namespacedName
);
err
!=
nil
{
if
err
:=
s
.
delete
(
obj
,
namespacedName
);
err
!=
nil
{
glog
.
Errorf
(
"Failed to delete %s %s: %v"
,
kind
,
namespacedName
,
err
)
glog
.
Errorf
(
"Failed to delete %s %s: %v"
,
kind
,
namespacedName
,
err
)
s
.
eventRecorder
.
Eventf
(
obj
,
api
.
EventType
Normal
,
"DeleteFailed"
,
s
.
eventRecorder
.
Eventf
(
obj
,
api
.
EventType
Warning
,
"DeleteFailed"
,
"%s delete failed: %v"
,
strings
.
ToTitle
(
kind
),
err
)
"%s delete failed: %v"
,
strings
.
ToTitle
(
kind
),
err
)
s
.
deliver
(
namespacedName
,
0
,
true
)
s
.
deliver
(
namespacedName
,
0
,
true
)
}
}
...
@@ -442,7 +442,7 @@ func (s *FederationSyncController) reconcile(namespacedName types.NamespacedName
...
@@ -442,7 +442,7 @@ func (s *FederationSyncController) reconcile(namespacedName types.NamespacedName
}
}
err
=
s
.
updater
.
UpdateWithOnError
(
operations
,
s
.
updateTimeout
,
err
=
s
.
updater
.
UpdateWithOnError
(
operations
,
s
.
updateTimeout
,
func
(
op
util
.
FederatedOperation
,
operror
error
)
{
func
(
op
util
.
FederatedOperation
,
operror
error
)
{
s
.
eventRecorder
.
Eventf
(
obj
,
api
.
EventType
Normal
,
"UpdateInClusterFailed"
,
s
.
eventRecorder
.
Eventf
(
obj
,
api
.
EventType
Warning
,
"UpdateInClusterFailed"
,
"%s update in cluster %s failed: %v"
,
strings
.
ToTitle
(
kind
),
op
.
ClusterName
,
operror
)
"%s update in cluster %s failed: %v"
,
strings
.
ToTitle
(
kind
),
op
.
ClusterName
,
operror
)
})
})
...
...
federation/pkg/federation-controller/util/deletionhelper/deletion_helper.go
View file @
5c94d422
...
@@ -152,7 +152,7 @@ func (dh *DeletionHelper) HandleObjectInUnderlyingClusters(obj runtime.Object) (
...
@@ -152,7 +152,7 @@ func (dh *DeletionHelper) HandleObjectInUnderlyingClusters(obj runtime.Object) (
}
}
err
=
dh
.
updater
.
UpdateWithOnError
(
operations
,
dh
.
updateTimeout
,
func
(
op
util
.
FederatedOperation
,
operror
error
)
{
err
=
dh
.
updater
.
UpdateWithOnError
(
operations
,
dh
.
updateTimeout
,
func
(
op
util
.
FederatedOperation
,
operror
error
)
{
objName
:=
dh
.
objNameFunc
(
op
.
Obj
)
objName
:=
dh
.
objNameFunc
(
op
.
Obj
)
dh
.
eventRecorder
.
Eventf
(
obj
,
api
.
EventType
Normal
,
"DeleteInClusterFailed"
,
dh
.
eventRecorder
.
Eventf
(
obj
,
api
.
EventType
Warning
,
"DeleteInClusterFailed"
,
"Failed to delete obj %s in cluster %s: %v"
,
objName
,
op
.
ClusterName
,
operror
)
"Failed to delete obj %s in cluster %s: %v"
,
objName
,
op
.
ClusterName
,
operror
)
})
})
if
err
!=
nil
{
if
err
!=
nil
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment