Merge pull request #57140 from niuzhenguo/noheaders-linebreak

Automatic merge from submit-queue (batch tested with PRs 56947, 56349, 57140, 53686, 57314). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Kubectl: Move no-headers flag get out of for loop **What this PR does / why we need it**: This makes no-headers flag get before the for loop happen, there's no need to get the flag multiple times. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```

Merge pull request #57140 from niuzhenguo/noheaders-linebreak
5c17bec9 · Kubernetes Submit Queue · GitHub · b6b1762a · 7cccb94e · 5c17bec9
Unverified Commit 5c17bec9 authored Dec 18, 2017 by Kubernetes Submit Queue Committed by GitHub Dec 18, 2017
Show whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

get.go pkg/kubectl/cmd/resource/get.go +1 -1

No files found.
--- a/pkg/kubectl/cmd/resource/get.go
+++ b/pkg/kubectl/cmd/resource/get.go
@@ -308,6 +308,7 @@ func (options *GetOptions) Run(f cmdutil.Factory, cmd *cobra.Command, args []str
 	}
 	filteredResourceCount := 0
+	noHeaders := cmdutil.GetFlagBool(cmd, "no-headers")
 	for ix := range objs {
 		var mapping *meta.RESTMapping
 		var original runtime.Object
@@ -350,7 +351,6 @@ func (options *GetOptions) Run(f cmdutil.Factory, cmd *cobra.Command, args []str
 			// TODO: this doesn't belong here
 			// add linebreak between resource groups (if there is more than one)
 			// skip linebreak above first resource group
-			noHeaders := cmdutil.GetFlagBool(cmd, "no-headers")
 			if lastMapping != nil && !noHeaders {
 				fmt.Fprintf(options.ErrOut, "%s\n", "")
 			}