Unverified Commit 42157746 authored by k8s-ci-robot's avatar k8s-ci-robot Committed by GitHub

Merge pull request #68634 from seans3/remove-internal-version

Replace internal version of resource with external version for tests
parents 2adecd04 4e8e2705
...@@ -69,10 +69,6 @@ go_test( ...@@ -69,10 +69,6 @@ go_test(
], ],
embed = [":go_default_library"], embed = [":go_default_library"],
deps = [ deps = [
"//pkg/apis/apps:go_default_library",
"//pkg/apis/batch:go_default_library",
"//pkg/apis/core:go_default_library",
"//pkg/apis/extensions:go_default_library",
"//pkg/controller:go_default_library", "//pkg/controller:go_default_library",
"//staging/src/k8s.io/api/apps/v1:go_default_library", "//staging/src/k8s.io/api/apps/v1:go_default_library",
"//staging/src/k8s.io/api/apps/v1beta1:go_default_library", "//staging/src/k8s.io/api/apps/v1beta1:go_default_library",
......
...@@ -19,16 +19,20 @@ package polymorphichelpers ...@@ -19,16 +19,20 @@ package polymorphichelpers
import ( import (
"fmt" "fmt"
appsv1 "k8s.io/api/apps/v1"
corev1 "k8s.io/api/core/v1"
extensionsv1beta1 "k8s.io/api/extensions/v1beta1"
"k8s.io/apimachinery/pkg/runtime/schema" "k8s.io/apimachinery/pkg/runtime/schema"
"k8s.io/kubernetes/pkg/apis/apps"
api "k8s.io/kubernetes/pkg/apis/core"
"k8s.io/kubernetes/pkg/apis/extensions"
) )
func canBeAutoscaled(kind schema.GroupKind) error { func canBeAutoscaled(kind schema.GroupKind) error {
switch kind { switch kind {
case api.Kind("ReplicationController"), extensions.Kind("ReplicaSet"), case
extensions.Kind("Deployment"), apps.Kind("Deployment"), apps.Kind("ReplicaSet"): corev1.SchemeGroupVersion.WithKind("ReplicationController").GroupKind(),
appsv1.SchemeGroupVersion.WithKind("Deployment").GroupKind(),
appsv1.SchemeGroupVersion.WithKind("ReplicaSet").GroupKind(),
extensionsv1beta1.SchemeGroupVersion.WithKind("Deployment").GroupKind(),
extensionsv1beta1.SchemeGroupVersion.WithKind("ReplicaSet").GroupKind():
// nothing to do here // nothing to do here
default: default:
return fmt.Errorf("cannot autoscale a %v", kind) return fmt.Errorf("cannot autoscale a %v", kind)
......
...@@ -19,8 +19,10 @@ package polymorphichelpers ...@@ -19,8 +19,10 @@ package polymorphichelpers
import ( import (
"testing" "testing"
appsv1 "k8s.io/api/apps/v1"
corev1 "k8s.io/api/core/v1"
extensionsv1beta1 "k8s.io/api/extensions/v1beta1"
"k8s.io/apimachinery/pkg/runtime/schema" "k8s.io/apimachinery/pkg/runtime/schema"
api "k8s.io/kubernetes/pkg/apis/core"
) )
func TestCanBeAutoscaled(t *testing.T) { func TestCanBeAutoscaled(t *testing.T) {
...@@ -29,11 +31,27 @@ func TestCanBeAutoscaled(t *testing.T) { ...@@ -29,11 +31,27 @@ func TestCanBeAutoscaled(t *testing.T) {
expectErr bool expectErr bool
}{ }{
{ {
kind: api.Kind("ReplicationController"), kind: corev1.SchemeGroupVersion.WithKind("ReplicationController").GroupKind(),
expectErr: false, expectErr: false,
}, },
{ {
kind: api.Kind("Node"), kind: appsv1.SchemeGroupVersion.WithKind("Deployment").GroupKind(),
expectErr: false,
},
{
kind: extensionsv1beta1.SchemeGroupVersion.WithKind("ReplicaSet").GroupKind(),
expectErr: false,
},
{
kind: corev1.SchemeGroupVersion.WithKind("Node").GroupKind(),
expectErr: true,
},
{
kind: corev1.SchemeGroupVersion.WithKind("Service").GroupKind(),
expectErr: true,
},
{
kind: corev1.SchemeGroupVersion.WithKind("Pod").GroupKind(),
expectErr: true, expectErr: true,
}, },
} }
......
...@@ -19,17 +19,23 @@ package polymorphichelpers ...@@ -19,17 +19,23 @@ package polymorphichelpers
import ( import (
"fmt" "fmt"
appsv1 "k8s.io/api/apps/v1"
corev1 "k8s.io/api/core/v1"
extensionsv1beta1 "k8s.io/api/extensions/v1beta1"
"k8s.io/apimachinery/pkg/runtime/schema" "k8s.io/apimachinery/pkg/runtime/schema"
"k8s.io/kubernetes/pkg/apis/apps"
api "k8s.io/kubernetes/pkg/apis/core"
"k8s.io/kubernetes/pkg/apis/extensions"
) )
// Check whether the kind of resources could be exposed // Check whether the kind of resources could be exposed
func canBeExposed(kind schema.GroupKind) error { func canBeExposed(kind schema.GroupKind) error {
switch kind { switch kind {
case api.Kind("ReplicationController"), api.Kind("Service"), api.Kind("Pod"), case
extensions.Kind("Deployment"), apps.Kind("Deployment"), extensions.Kind("ReplicaSet"), apps.Kind("ReplicaSet"): corev1.SchemeGroupVersion.WithKind("ReplicationController").GroupKind(),
corev1.SchemeGroupVersion.WithKind("Service").GroupKind(),
corev1.SchemeGroupVersion.WithKind("Pod").GroupKind(),
appsv1.SchemeGroupVersion.WithKind("Deployment").GroupKind(),
appsv1.SchemeGroupVersion.WithKind("ReplicaSet").GroupKind(),
extensionsv1beta1.SchemeGroupVersion.WithKind("Deployment").GroupKind(),
extensionsv1beta1.SchemeGroupVersion.WithKind("ReplicaSet").GroupKind():
// nothing to do here // nothing to do here
default: default:
return fmt.Errorf("cannot expose a %s", kind) return fmt.Errorf("cannot expose a %s", kind)
......
...@@ -19,8 +19,10 @@ package polymorphichelpers ...@@ -19,8 +19,10 @@ package polymorphichelpers
import ( import (
"testing" "testing"
appsv1 "k8s.io/api/apps/v1"
corev1 "k8s.io/api/core/v1"
extensionsv1beta1 "k8s.io/api/extensions/v1beta1"
"k8s.io/apimachinery/pkg/runtime/schema" "k8s.io/apimachinery/pkg/runtime/schema"
api "k8s.io/kubernetes/pkg/apis/core"
) )
func TestCanBeExposed(t *testing.T) { func TestCanBeExposed(t *testing.T) {
...@@ -29,11 +31,27 @@ func TestCanBeExposed(t *testing.T) { ...@@ -29,11 +31,27 @@ func TestCanBeExposed(t *testing.T) {
expectErr bool expectErr bool
}{ }{
{ {
kind: api.Kind("ReplicationController"), kind: corev1.SchemeGroupVersion.WithKind("ReplicationController").GroupKind(),
expectErr: false, expectErr: false,
}, },
{ {
kind: api.Kind("Node"), kind: corev1.SchemeGroupVersion.WithKind("Service").GroupKind(),
expectErr: false,
},
{
kind: corev1.SchemeGroupVersion.WithKind("Pod").GroupKind(),
expectErr: false,
},
{
kind: appsv1.SchemeGroupVersion.WithKind("Deployment").GroupKind(),
expectErr: false,
},
{
kind: extensionsv1beta1.SchemeGroupVersion.WithKind("ReplicaSet").GroupKind(),
expectErr: false,
},
{
kind: corev1.SchemeGroupVersion.WithKind("Node").GroupKind(),
expectErr: true, expectErr: true,
}, },
} }
......
...@@ -29,7 +29,6 @@ import ( ...@@ -29,7 +29,6 @@ import (
"k8s.io/apimachinery/pkg/watch" "k8s.io/apimachinery/pkg/watch"
fakeexternal "k8s.io/client-go/kubernetes/fake" fakeexternal "k8s.io/client-go/kubernetes/fake"
testcore "k8s.io/client-go/testing" testcore "k8s.io/client-go/testing"
api "k8s.io/kubernetes/pkg/apis/core"
"k8s.io/kubernetes/pkg/controller" "k8s.io/kubernetes/pkg/controller"
) )
...@@ -119,18 +118,18 @@ func TestGetFirstPod(t *testing.T) { ...@@ -119,18 +118,18 @@ func TestGetFirstPod(t *testing.T) {
watching: []watch.Event{ watching: []watch.Event{
{ {
Type: watch.Modified, Type: watch.Modified,
Object: &api.Pod{ Object: &corev1.Pod{
ObjectMeta: metav1.ObjectMeta{ ObjectMeta: metav1.ObjectMeta{
Name: "pod-1", Name: "pod-1",
Namespace: metav1.NamespaceDefault, Namespace: metav1.NamespaceDefault,
CreationTimestamp: metav1.Date(2016, time.April, 1, 1, 0, 0, 0, time.UTC), CreationTimestamp: metav1.Date(2016, time.April, 1, 1, 0, 0, 0, time.UTC),
Labels: map[string]string{"test": "selector"}, Labels: map[string]string{"test": "selector"},
}, },
Status: api.PodStatus{ Status: corev1.PodStatus{
Conditions: []api.PodCondition{ Conditions: []corev1.PodCondition{
{ {
Status: api.ConditionTrue, Status: corev1.ConditionTrue,
Type: api.PodReady, Type: corev1.PodReady,
}, },
}, },
}, },
......
...@@ -21,16 +21,16 @@ import ( ...@@ -21,16 +21,16 @@ import (
"testing" "testing"
"time" "time"
appsv1 "k8s.io/api/apps/v1"
batchv1 "k8s.io/api/batch/v1"
corev1 "k8s.io/api/core/v1" corev1 "k8s.io/api/core/v1"
extensionsv1beta1 "k8s.io/api/extensions/v1beta1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/runtime/schema" "k8s.io/apimachinery/pkg/runtime/schema"
"k8s.io/apimachinery/pkg/util/diff" "k8s.io/apimachinery/pkg/util/diff"
fakeexternal "k8s.io/client-go/kubernetes/fake" fakeexternal "k8s.io/client-go/kubernetes/fake"
testclient "k8s.io/client-go/testing" testclient "k8s.io/client-go/testing"
"k8s.io/kubernetes/pkg/apis/apps"
"k8s.io/kubernetes/pkg/apis/batch"
"k8s.io/kubernetes/pkg/apis/extensions"
) )
var ( var (
...@@ -151,9 +151,9 @@ func TestLogsForObject(t *testing.T) { ...@@ -151,9 +151,9 @@ func TestLogsForObject(t *testing.T) {
}, },
{ {
name: "replica set logs", name: "replica set logs",
obj: &extensions.ReplicaSet{ obj: &extensionsv1beta1.ReplicaSet{
ObjectMeta: metav1.ObjectMeta{Name: "hello", Namespace: "test"}, ObjectMeta: metav1.ObjectMeta{Name: "hello", Namespace: "test"},
Spec: extensions.ReplicaSetSpec{ Spec: extensionsv1beta1.ReplicaSetSpec{
Selector: &metav1.LabelSelector{MatchLabels: map[string]string{"foo": "bar"}}, Selector: &metav1.LabelSelector{MatchLabels: map[string]string{"foo": "bar"}},
}, },
}, },
...@@ -165,9 +165,9 @@ func TestLogsForObject(t *testing.T) { ...@@ -165,9 +165,9 @@ func TestLogsForObject(t *testing.T) {
}, },
{ {
name: "deployment logs", name: "deployment logs",
obj: &extensions.Deployment{ obj: &extensionsv1beta1.Deployment{
ObjectMeta: metav1.ObjectMeta{Name: "hello", Namespace: "test"}, ObjectMeta: metav1.ObjectMeta{Name: "hello", Namespace: "test"},
Spec: extensions.DeploymentSpec{ Spec: extensionsv1beta1.DeploymentSpec{
Selector: &metav1.LabelSelector{MatchLabels: map[string]string{"foo": "bar"}}, Selector: &metav1.LabelSelector{MatchLabels: map[string]string{"foo": "bar"}},
}, },
}, },
...@@ -179,9 +179,9 @@ func TestLogsForObject(t *testing.T) { ...@@ -179,9 +179,9 @@ func TestLogsForObject(t *testing.T) {
}, },
{ {
name: "job logs", name: "job logs",
obj: &batch.Job{ obj: &batchv1.Job{
ObjectMeta: metav1.ObjectMeta{Name: "hello", Namespace: "test"}, ObjectMeta: metav1.ObjectMeta{Name: "hello", Namespace: "test"},
Spec: batch.JobSpec{ Spec: batchv1.JobSpec{
Selector: &metav1.LabelSelector{MatchLabels: map[string]string{"foo": "bar"}}, Selector: &metav1.LabelSelector{MatchLabels: map[string]string{"foo": "bar"}},
}, },
}, },
...@@ -193,9 +193,9 @@ func TestLogsForObject(t *testing.T) { ...@@ -193,9 +193,9 @@ func TestLogsForObject(t *testing.T) {
}, },
{ {
name: "stateful set logs", name: "stateful set logs",
obj: &apps.StatefulSet{ obj: &appsv1.StatefulSet{
ObjectMeta: metav1.ObjectMeta{Name: "hello", Namespace: "test"}, ObjectMeta: metav1.ObjectMeta{Name: "hello", Namespace: "test"},
Spec: apps.StatefulSetSpec{ Spec: appsv1.StatefulSetSpec{
Selector: &metav1.LabelSelector{MatchLabels: map[string]string{"foo": "bar"}}, Selector: &metav1.LabelSelector{MatchLabels: map[string]string{"foo": "bar"}},
}, },
}, },
......
...@@ -19,10 +19,10 @@ package polymorphichelpers ...@@ -19,10 +19,10 @@ package polymorphichelpers
import ( import (
"testing" "testing"
corev1 "k8s.io/api/core/v1"
extensionsv1beta1 "k8s.io/api/extensions/v1beta1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/runtime"
api "k8s.io/kubernetes/pkg/apis/core"
"k8s.io/kubernetes/pkg/apis/extensions"
) )
func TestMapBasedSelectorForObject(t *testing.T) { func TestMapBasedSelectorForObject(t *testing.T) {
...@@ -32,8 +32,8 @@ func TestMapBasedSelectorForObject(t *testing.T) { ...@@ -32,8 +32,8 @@ func TestMapBasedSelectorForObject(t *testing.T) {
expectErr bool expectErr bool
}{ }{
{ {
object: &api.ReplicationController{ object: &corev1.ReplicationController{
Spec: api.ReplicationControllerSpec{ Spec: corev1.ReplicationControllerSpec{
Selector: map[string]string{ Selector: map[string]string{
"foo": "bar", "foo": "bar",
}, },
...@@ -42,11 +42,11 @@ func TestMapBasedSelectorForObject(t *testing.T) { ...@@ -42,11 +42,11 @@ func TestMapBasedSelectorForObject(t *testing.T) {
expectSelector: "foo=bar", expectSelector: "foo=bar",
}, },
{ {
object: &api.Pod{}, object: &corev1.Pod{},
expectErr: true, expectErr: true,
}, },
{ {
object: &api.Pod{ object: &corev1.Pod{
ObjectMeta: metav1.ObjectMeta{ ObjectMeta: metav1.ObjectMeta{
Labels: map[string]string{ Labels: map[string]string{
"foo": "bar", "foo": "bar",
...@@ -56,8 +56,8 @@ func TestMapBasedSelectorForObject(t *testing.T) { ...@@ -56,8 +56,8 @@ func TestMapBasedSelectorForObject(t *testing.T) {
expectSelector: "foo=bar", expectSelector: "foo=bar",
}, },
{ {
object: &api.Service{ object: &corev1.Service{
Spec: api.ServiceSpec{ Spec: corev1.ServiceSpec{
Selector: map[string]string{ Selector: map[string]string{
"foo": "bar", "foo": "bar",
}, },
...@@ -66,12 +66,12 @@ func TestMapBasedSelectorForObject(t *testing.T) { ...@@ -66,12 +66,12 @@ func TestMapBasedSelectorForObject(t *testing.T) {
expectSelector: "foo=bar", expectSelector: "foo=bar",
}, },
{ {
object: &api.Service{}, object: &corev1.Service{},
expectErr: true, expectErr: true,
}, },
{ {
object: &extensions.Deployment{ object: &extensionsv1beta1.Deployment{
Spec: extensions.DeploymentSpec{ Spec: extensionsv1beta1.DeploymentSpec{
Selector: &metav1.LabelSelector{ Selector: &metav1.LabelSelector{
MatchLabels: map[string]string{ MatchLabels: map[string]string{
"foo": "bar", "foo": "bar",
...@@ -82,8 +82,8 @@ func TestMapBasedSelectorForObject(t *testing.T) { ...@@ -82,8 +82,8 @@ func TestMapBasedSelectorForObject(t *testing.T) {
expectSelector: "foo=bar", expectSelector: "foo=bar",
}, },
{ {
object: &extensions.Deployment{ object: &extensionsv1beta1.Deployment{
Spec: extensions.DeploymentSpec{ Spec: extensionsv1beta1.DeploymentSpec{
Selector: &metav1.LabelSelector{ Selector: &metav1.LabelSelector{
MatchExpressions: []metav1.LabelSelectorRequirement{ MatchExpressions: []metav1.LabelSelectorRequirement{
{ {
...@@ -96,8 +96,8 @@ func TestMapBasedSelectorForObject(t *testing.T) { ...@@ -96,8 +96,8 @@ func TestMapBasedSelectorForObject(t *testing.T) {
expectErr: true, expectErr: true,
}, },
{ {
object: &extensions.ReplicaSet{ object: &extensionsv1beta1.ReplicaSet{
Spec: extensions.ReplicaSetSpec{ Spec: extensionsv1beta1.ReplicaSetSpec{
Selector: &metav1.LabelSelector{ Selector: &metav1.LabelSelector{
MatchLabels: map[string]string{ MatchLabels: map[string]string{
"foo": "bar", "foo": "bar",
...@@ -108,8 +108,8 @@ func TestMapBasedSelectorForObject(t *testing.T) { ...@@ -108,8 +108,8 @@ func TestMapBasedSelectorForObject(t *testing.T) {
expectSelector: "foo=bar", expectSelector: "foo=bar",
}, },
{ {
object: &extensions.ReplicaSet{ object: &extensionsv1beta1.ReplicaSet{
Spec: extensions.ReplicaSetSpec{ Spec: extensionsv1beta1.ReplicaSetSpec{
Selector: &metav1.LabelSelector{ Selector: &metav1.LabelSelector{
MatchExpressions: []metav1.LabelSelectorRequirement{ MatchExpressions: []metav1.LabelSelectorRequirement{
{ {
...@@ -122,7 +122,7 @@ func TestMapBasedSelectorForObject(t *testing.T) { ...@@ -122,7 +122,7 @@ func TestMapBasedSelectorForObject(t *testing.T) {
expectErr: true, expectErr: true,
}, },
{ {
object: &api.Node{}, object: &corev1.Node{},
expectErr: true, expectErr: true,
}, },
} }
......
...@@ -20,8 +20,8 @@ import ( ...@@ -20,8 +20,8 @@ import (
"bytes" "bytes"
"testing" "testing"
extensionsv1beta1 "k8s.io/api/extensions/v1beta1"
"k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/runtime"
"k8s.io/kubernetes/pkg/apis/extensions"
) )
func TestDefaultObjectPauser(t *testing.T) { func TestDefaultObjectPauser(t *testing.T) {
...@@ -31,8 +31,8 @@ func TestDefaultObjectPauser(t *testing.T) { ...@@ -31,8 +31,8 @@ func TestDefaultObjectPauser(t *testing.T) {
expectErr bool expectErr bool
}{ }{
{ {
object: &extensions.Deployment{ object: &extensionsv1beta1.Deployment{
Spec: extensions.DeploymentSpec{ Spec: extensionsv1beta1.DeploymentSpec{
Paused: false, Paused: false,
}, },
}, },
...@@ -40,15 +40,15 @@ func TestDefaultObjectPauser(t *testing.T) { ...@@ -40,15 +40,15 @@ func TestDefaultObjectPauser(t *testing.T) {
expectErr: false, expectErr: false,
}, },
{ {
object: &extensions.Deployment{ object: &extensionsv1beta1.Deployment{
Spec: extensions.DeploymentSpec{ Spec: extensionsv1beta1.DeploymentSpec{
Paused: true, Paused: true,
}, },
}, },
expectErr: true, expectErr: true,
}, },
{ {
object: &extensions.ReplicaSet{}, object: &extensionsv1beta1.ReplicaSet{},
expectErr: true, expectErr: true,
}, },
} }
......
...@@ -20,8 +20,8 @@ import ( ...@@ -20,8 +20,8 @@ import (
"bytes" "bytes"
"testing" "testing"
extensionsv1beta1 "k8s.io/api/extensions/v1beta1"
"k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/runtime"
"k8s.io/kubernetes/pkg/apis/extensions"
) )
func TestDefaultObjectResumer(t *testing.T) { func TestDefaultObjectResumer(t *testing.T) {
...@@ -31,8 +31,8 @@ func TestDefaultObjectResumer(t *testing.T) { ...@@ -31,8 +31,8 @@ func TestDefaultObjectResumer(t *testing.T) {
expectErr bool expectErr bool
}{ }{
{ {
object: &extensions.Deployment{ object: &extensionsv1beta1.Deployment{
Spec: extensions.DeploymentSpec{ Spec: extensionsv1beta1.DeploymentSpec{
Paused: true, Paused: true,
}, },
}, },
...@@ -40,15 +40,15 @@ func TestDefaultObjectResumer(t *testing.T) { ...@@ -40,15 +40,15 @@ func TestDefaultObjectResumer(t *testing.T) {
expectErr: false, expectErr: false,
}, },
{ {
object: &extensions.Deployment{ object: &extensionsv1beta1.Deployment{
Spec: extensions.DeploymentSpec{ Spec: extensionsv1beta1.DeploymentSpec{
Paused: false, Paused: false,
}, },
}, },
expectErr: true, expectErr: true,
}, },
{ {
object: &extensions.ReplicaSet{}, object: &extensionsv1beta1.ReplicaSet{},
expectErr: true, expectErr: true,
}, },
} }
......
...@@ -21,9 +21,9 @@ import ( ...@@ -21,9 +21,9 @@ import (
"reflect" "reflect"
corev1 "k8s.io/api/core/v1"
extensionsv1beta1 "k8s.io/api/extensions/v1beta1"
"k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/runtime"
api "k8s.io/kubernetes/pkg/apis/core"
"k8s.io/kubernetes/pkg/apis/extensions"
) )
func TestPortsForObject(t *testing.T) { func TestPortsForObject(t *testing.T) {
...@@ -32,11 +32,11 @@ func TestPortsForObject(t *testing.T) { ...@@ -32,11 +32,11 @@ func TestPortsForObject(t *testing.T) {
expectErr bool expectErr bool
}{ }{
{ {
object: &api.Pod{ object: &corev1.Pod{
Spec: api.PodSpec{ Spec: corev1.PodSpec{
Containers: []api.Container{ Containers: []corev1.Container{
{ {
Ports: []api.ContainerPort{ Ports: []corev1.ContainerPort{
{ {
ContainerPort: 101, ContainerPort: 101,
}, },
...@@ -47,9 +47,9 @@ func TestPortsForObject(t *testing.T) { ...@@ -47,9 +47,9 @@ func TestPortsForObject(t *testing.T) {
}, },
}, },
{ {
object: &api.Service{ object: &corev1.Service{
Spec: api.ServiceSpec{ Spec: corev1.ServiceSpec{
Ports: []api.ServicePort{ Ports: []corev1.ServicePort{
{ {
Port: 101, Port: 101,
}, },
...@@ -58,13 +58,13 @@ func TestPortsForObject(t *testing.T) { ...@@ -58,13 +58,13 @@ func TestPortsForObject(t *testing.T) {
}, },
}, },
{ {
object: &api.ReplicationController{ object: &corev1.ReplicationController{
Spec: api.ReplicationControllerSpec{ Spec: corev1.ReplicationControllerSpec{
Template: &api.PodTemplateSpec{ Template: &corev1.PodTemplateSpec{
Spec: api.PodSpec{ Spec: corev1.PodSpec{
Containers: []api.Container{ Containers: []corev1.Container{
{ {
Ports: []api.ContainerPort{ Ports: []corev1.ContainerPort{
{ {
ContainerPort: 101, ContainerPort: 101,
}, },
...@@ -77,13 +77,13 @@ func TestPortsForObject(t *testing.T) { ...@@ -77,13 +77,13 @@ func TestPortsForObject(t *testing.T) {
}, },
}, },
{ {
object: &extensions.Deployment{ object: &extensionsv1beta1.Deployment{
Spec: extensions.DeploymentSpec{ Spec: extensionsv1beta1.DeploymentSpec{
Template: api.PodTemplateSpec{ Template: corev1.PodTemplateSpec{
Spec: api.PodSpec{ Spec: corev1.PodSpec{
Containers: []api.Container{ Containers: []corev1.Container{
{ {
Ports: []api.ContainerPort{ Ports: []corev1.ContainerPort{
{ {
ContainerPort: 101, ContainerPort: 101,
}, },
...@@ -96,13 +96,13 @@ func TestPortsForObject(t *testing.T) { ...@@ -96,13 +96,13 @@ func TestPortsForObject(t *testing.T) {
}, },
}, },
{ {
object: &extensions.ReplicaSet{ object: &extensionsv1beta1.ReplicaSet{
Spec: extensions.ReplicaSetSpec{ Spec: extensionsv1beta1.ReplicaSetSpec{
Template: api.PodTemplateSpec{ Template: corev1.PodTemplateSpec{
Spec: api.PodSpec{ Spec: corev1.PodSpec{
Containers: []api.Container{ Containers: []corev1.Container{
{ {
Ports: []api.ContainerPort{ Ports: []corev1.ContainerPort{
{ {
ContainerPort: 101, ContainerPort: 101,
}, },
...@@ -115,7 +115,7 @@ func TestPortsForObject(t *testing.T) { ...@@ -115,7 +115,7 @@ func TestPortsForObject(t *testing.T) {
}, },
}, },
{ {
object: &api.Node{}, object: &corev1.Node{},
expectErr: true, expectErr: true,
}, },
} }
......
...@@ -21,9 +21,9 @@ import ( ...@@ -21,9 +21,9 @@ import (
"reflect" "reflect"
corev1 "k8s.io/api/core/v1"
extensionsv1beta1 "k8s.io/api/extensions/v1beta1"
"k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/runtime"
api "k8s.io/kubernetes/pkg/apis/core"
"k8s.io/kubernetes/pkg/apis/extensions"
) )
func TestProtocolsForObject(t *testing.T) { func TestProtocolsForObject(t *testing.T) {
...@@ -32,11 +32,11 @@ func TestProtocolsForObject(t *testing.T) { ...@@ -32,11 +32,11 @@ func TestProtocolsForObject(t *testing.T) {
expectErr bool expectErr bool
}{ }{
{ {
object: &api.Pod{ object: &corev1.Pod{
Spec: api.PodSpec{ Spec: corev1.PodSpec{
Containers: []api.Container{ Containers: []corev1.Container{
{ {
Ports: []api.ContainerPort{ Ports: []corev1.ContainerPort{
{ {
ContainerPort: 101, ContainerPort: 101,
Protocol: "tcp", Protocol: "tcp",
...@@ -48,9 +48,9 @@ func TestProtocolsForObject(t *testing.T) { ...@@ -48,9 +48,9 @@ func TestProtocolsForObject(t *testing.T) {
}, },
}, },
{ {
object: &api.Service{ object: &corev1.Service{
Spec: api.ServiceSpec{ Spec: corev1.ServiceSpec{
Ports: []api.ServicePort{ Ports: []corev1.ServicePort{
{ {
Port: 101, Port: 101,
Protocol: "tcp", Protocol: "tcp",
...@@ -60,13 +60,13 @@ func TestProtocolsForObject(t *testing.T) { ...@@ -60,13 +60,13 @@ func TestProtocolsForObject(t *testing.T) {
}, },
}, },
{ {
object: &api.ReplicationController{ object: &corev1.ReplicationController{
Spec: api.ReplicationControllerSpec{ Spec: corev1.ReplicationControllerSpec{
Template: &api.PodTemplateSpec{ Template: &corev1.PodTemplateSpec{
Spec: api.PodSpec{ Spec: corev1.PodSpec{
Containers: []api.Container{ Containers: []corev1.Container{
{ {
Ports: []api.ContainerPort{ Ports: []corev1.ContainerPort{
{ {
ContainerPort: 101, ContainerPort: 101,
Protocol: "tcp", Protocol: "tcp",
...@@ -80,13 +80,13 @@ func TestProtocolsForObject(t *testing.T) { ...@@ -80,13 +80,13 @@ func TestProtocolsForObject(t *testing.T) {
}, },
}, },
{ {
object: &extensions.Deployment{ object: &extensionsv1beta1.Deployment{
Spec: extensions.DeploymentSpec{ Spec: extensionsv1beta1.DeploymentSpec{
Template: api.PodTemplateSpec{ Template: corev1.PodTemplateSpec{
Spec: api.PodSpec{ Spec: corev1.PodSpec{
Containers: []api.Container{ Containers: []corev1.Container{
{ {
Ports: []api.ContainerPort{ Ports: []corev1.ContainerPort{
{ {
ContainerPort: 101, ContainerPort: 101,
Protocol: "tcp", Protocol: "tcp",
...@@ -100,13 +100,13 @@ func TestProtocolsForObject(t *testing.T) { ...@@ -100,13 +100,13 @@ func TestProtocolsForObject(t *testing.T) {
}, },
}, },
{ {
object: &extensions.ReplicaSet{ object: &extensionsv1beta1.ReplicaSet{
Spec: extensions.ReplicaSetSpec{ Spec: extensionsv1beta1.ReplicaSetSpec{
Template: api.PodTemplateSpec{ Template: corev1.PodTemplateSpec{
Spec: api.PodSpec{ Spec: corev1.PodSpec{
Containers: []api.Container{ Containers: []corev1.Container{
{ {
Ports: []api.ContainerPort{ Ports: []corev1.ContainerPort{
{ {
ContainerPort: 101, ContainerPort: 101,
Protocol: "tcp", Protocol: "tcp",
...@@ -120,7 +120,7 @@ func TestProtocolsForObject(t *testing.T) { ...@@ -120,7 +120,7 @@ func TestProtocolsForObject(t *testing.T) {
}, },
}, },
{ {
object: &api.Node{}, object: &corev1.Node{},
expectErr: true, expectErr: true,
}, },
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment