Change TimeAdded to pointer

cmd/kubeadm/app/phases/markmaster/markmaster_test.go

@@ -49,7 +49,7 @@ func TestMarkMaster(t *testing.T) {
 			"master label and taint missing",
 			"",
 			nil,
-			"{\"metadata\":{\"labels\":{\"node-role.kubernetes.io/master\":\"\"}},\"spec\":{\"taints\":[{\"effect\":\"NoSchedule\",\"key\":\"node-role.kubernetes.io/master\",\"timeAdded\":null}]}}",
+			"{\"metadata\":{\"labels\":{\"node-role.kubernetes.io/master\":\"\"}},\"spec\":{\"taints\":[{\"effect\":\"NoSchedule\",\"key\":\"node-role.kubernetes.io/master\"}]}}",
 		},
 		{
 			"master label missing",
@@ -61,7 +61,7 @@ func TestMarkMaster(t *testing.T) {
 			"master taint missing",
 			kubeadmconstants.LabelNodeRoleMaster,
 			nil,
-			"{\"spec\":{\"taints\":[{\"effect\":\"NoSchedule\",\"key\":\"node-role.kubernetes.io/master\",\"timeAdded\":null}]}}",
+			"{\"spec\":{\"taints\":[{\"effect\":\"NoSchedule\",\"key\":\"node-role.kubernetes.io/master\"}]}}",
 		},
 		{
 			"nothing missing",

pkg/api/types.go

@@ -2229,7 +2229,7 @@ type Taint struct {
 	// TimeAdded represents the time at which the taint was added.
 	// It is only written for NoExecute taints.
 	// +optional
-	TimeAdded metav1.Time
+	TimeAdded *metav1.Time
 }
 
 type TaintEffect string

pkg/controller/daemon/daemon_controller_test.go

@@ -63,17 +63,22 @@ var (
 	noExecuteTaints       = []v1.Taint{{Key: "dedicated", Value: "user1", Effect: "NoExecute"}}
 )
 
+func nowPointer() *metav1.Time {
+	now := metav1.Now()
+	return &now
+}
+
 var (
 	nodeNotReady = []v1.Taint{{
 		Key:       algorithm.TaintNodeNotReady,
 		Effect:    v1.TaintEffectNoExecute,
-		TimeAdded: metav1.Now(),
+		TimeAdded: nowPointer(),
 	}}
 
 	nodeUnreachable = []v1.Taint{{
 		Key:       algorithm.TaintNodeUnreachable,
 		Effect:    v1.TaintEffectNoExecute,
-		TimeAdded: metav1.Now(),
+		TimeAdded: nowPointer(),
 	}}
 )
 

pkg/controller/node/scheduler/taint_controller_test.go

@@ -33,11 +33,12 @@ import (
 var timeForControllerToProgress = 500 * time.Millisecond
 
 func createNoExecuteTaint(index int) v1.Taint {
+	now := metav1.Now()
 	return v1.Taint{
 		Key:       "testTaint" + fmt.Sprintf("%v", index),
 		Value:     "test" + fmt.Sprintf("%v", index),
 		Effect:    v1.TaintEffectNoExecute,
-		TimeAdded: metav1.Now(),
+		TimeAdded: &now,
 	}
 }
 

pkg/controller/node/util/controller_utils.go

@@ -256,7 +256,8 @@ func RecordNodeStatusChange(recorder record.EventRecorder, node *v1.Node, newSta
 // otherwise.
 func SwapNodeControllerTaint(kubeClient clientset.Interface, taintsToAdd, taintsToRemove []*v1.Taint, node *v1.Node) bool {
 	for _, taintToAdd := range taintsToAdd {
-		taintToAdd.TimeAdded = metav1.Now()
+		now := metav1.Now()
+		taintToAdd.TimeAdded = &now
 	}
 
 	err := controller.AddOrUpdateTaintOnNode(kubeClient, node.Name, taintsToAdd...)

staging/src/k8s.io/api/core/v1/types.go

@@ -2466,7 +2466,7 @@ type Taint struct {
 	// TimeAdded represents the time at which the taint was added.
 	// It is only written for NoExecute taints.
 	// +optional
-	TimeAdded metav1.Time `json:"timeAdded,omitempty" protobuf:"bytes,4,opt,name=timeAdded"`
+	TimeAdded *metav1.Time `json:"timeAdded,omitempty" protobuf:"bytes,4,opt,name=timeAdded"`
 }
 
 type TaintEffect string

test/e2e/scheduling/taints_test.go

@@ -36,11 +36,12 @@ import (
 )
 
 func getTestTaint() v1.Taint {
+	now := metav1.Now()
 	return v1.Taint{
 		Key:       "kubernetes.io/e2e-evict-taint-key",
 		Value:     "evictTaintVal",
 		Effect:    v1.TaintEffectNoExecute,
-		TimeAdded: metav1.Now(),
+		TimeAdded: &now,
 	}
 }