Skip to content

K
k3s
Unverified Commit 2b1bfc3a authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub
Browse files
Options

Merge pull request #64361 from xlgao-zju/patch-1

Automatic merge from submit-queue (batch tested with PRs 61803, 64305, 64170, 64361, 64339). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Improve the help of kubeadm completion **What this PR does / why we need it**: Add note that 'bash-completion' is required on Linux too. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes [kubernetes/kubeadm/#860](https://github.com/kubernetes/kubeadm/issues/860) **Special notes for your reviewer**: cc @neolit123 **Release note**: ```release-note NONE ```
parents e978c47f 6d95bb3f
Show whitespace changes
Inline Side-by-side
Showing with 5 additions and 4 deletions
cmd/kubeadm/app/cmd/completion.go
View file @ 2b1bfc3a
...@@ -52,16 +52,17 @@ var ( ...@@ -52,16 +52,17 @@ var (
completion of kubeadm commands. This can be done by sourcing it from completion of kubeadm commands. This can be done by sourcing it from
the .bash_profile. the .bash_profile.
Note: this requires the bash-completion framework, which is not installed Note: this requires the bash-completion framework.
by default on Mac. This can be installed by using homebrew:
To install it on Mac use homebrew:
$ brew install bash-completion $ brew install bash-completion
Once installed, bash_completion must be evaluated. This can be done by adding the Once installed, bash_completion must be evaluated. This can be done by adding the
following line to the .bash_profile following line to the .bash_profile
$ source $(brew --prefix)/etc/bash_completion $ source $(brew --prefix)/etc/bash_completion
If bash-completion is not installed on Linux, please install the 'bash-completion' package
via your distribution's package manager.
Note for zsh users: [1] zsh completions are only supported in versions of zsh >= 5.2`) Note for zsh users: [1] zsh completions are only supported in versions of zsh >= 5.2`)
completionExample = dedent.Dedent(` completionExample = dedent.Dedent(`
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment