Merge pull request #45042 from wongma7/attaching-log

Automatic merge from submit-queue Log node name when error attaching volume Helps with debugging to know immediately which node the volume failed to atach to. Went through all plugins, added this to 3. @gnufied ```release-note NONE ```

Merge pull request #45042 from wongma7/attaching-log
19795ea7 · Kubernetes Submit Queue · GitHub · acca01bc · c8278a8a · 19795ea7
Commit 19795ea7 authored Apr 27, 2017 by Kubernetes Submit Queue Committed by GitHub Apr 27, 2017
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 3 deletions

attacher.go pkg/volume/aws_ebs/attacher.go +1 -1

attacher.go pkg/volume/photon_pd/attacher.go +1 -1

attacher.go pkg/volume/vsphere_volume/attacher.go +1 -1

No files found.
--- a/pkg/volume/aws_ebs/attacher.go
+++ b/pkg/volume/aws_ebs/attacher.go
@@ -70,7 +70,7 @@ func (attacher *awsElasticBlockStoreAttacher) Attach(spec *volume.Spec, nodeName
 	// succeeds in that case, so no need to do that separately.
 	devicePath, err := attacher.awsVolumes.AttachDisk(volumeID, nodeName, readOnly)
 	if err != nil {
-		glog.Errorf("Error attaching volume %q: %+v", volumeID, err)
+		glog.Errorf("Error attaching volume %q to node %q: %+v", volumeID, nodeName, err)
 		return "", err
 	}

--- a/pkg/volume/photon_pd/attacher.go
+++ b/pkg/volume/photon_pd/attacher.go
@@ -73,7 +73,7 @@ func (attacher *photonPersistentDiskAttacher) Attach(spec *volume.Spec, nodeName
 	// TODO: if disk is already attached?
 	err = attacher.photonDisks.AttachDisk(volumeSource.PdID, nodeName)
 	if err != nil {
-		glog.Errorf("Error attaching volume %q: %+v", volumeSource.PdID, err)
+		glog.Errorf("Error attaching volume %q to node %q: %+v", volumeSource.PdID, nodeName, err)
 		return "", err
 	}

--- a/pkg/volume/vsphere_volume/attacher.go
+++ b/pkg/volume/vsphere_volume/attacher.go
@@ -77,7 +77,7 @@ func (attacher *vsphereVMDKAttacher) Attach(spec *volume.Spec, nodeName types.No
 	// succeeds in that case, so no need to do that separately.
 	_, diskUUID, err := attacher.vsphereVolumes.AttachDisk(volumeSource.VolumePath, nodeName)
 	if err != nil {
-		glog.Errorf("Error attaching volume %q: %+v", volumeSource.VolumePath, err)
+		glog.Errorf("Error attaching volume %q to node %q: %+v", volumeSource.VolumePath, nodeName, err)
 		return "", err
 	}